This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Changed quoted text to be read as markup text instead of comment text.
Alhadis
reviewed
May 10, 2017
Contributor
Alhadis
left a comment
There was a problem hiding this comment.
I'd advise against this. I doubt there're many syntax themes which highlight the markup.quote scope, whereas the comment scope is more widely supported.
I think you'll find most of this grammar's scope-name choices are... strange and semantically inaccurate, but they're chosen to be as distinguishable as possible, IIUC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed quoted text to be read as markup text instead of comment text.
Requirements
Description of the Change
Changed syntax highlighting of quote text to correctly be read as markup text and not comment text.
Alternate Designs
None considered. Syntax matches that of other languages supported by Atom.
Benefits
Text will be highlighted correctly as quoted markup.
Possible Drawbacks
Text highlighting may render differently in custom Atom themes that were styled baed upon the previous incorrect syntax.
Applicable Issues
Addresses #185.