"-Wp,-U" breaks cross-builds using `zig cc`

[Leandros]

Problem:

Trying to cross-build the aws-lc-rs crate using zig-cross (which is using zig cc) fails due to zig cc not supporting the -Wp,option flag.

Relevant details

AWS-LC for Rust versions or commit: aws-lc-sys >= v0.35.0

Build log:

  cargo:warning=ToolExecError: command did not execute successfully (status code exit status: 1): LC_ALL="C" "/local/p4clients/pkgbuild-const/workspace/src/RedactedInstallPhaseX86/build/private/tmp/.cache/cargo-zigbuild/0.20.1/zigcc-x86_64-unknown-linux-gnu-de6.sh" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-gdwarf-4" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-unknown-linux-gnu" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/generated-include" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/include" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/aws-lc/include" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/aws-lc/third_party/s2n-bignum/include" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/aws-lc/third_party/s2n-bignum/s2n-bignum-imported/include" "-I" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/aws-lc/third_party/jitterentropy/jitterentropy-library" "-fwrapv" "--param" "ssp-buffer-size=4" "-fvisibility=hidden" "-Wcast-align" "-Wmissing-field-initializers" "-Wshadow" "-Wswitch-enum" "-Wextra" "-Wall" "-pedantic" "-O0" "-fwrapv" "-Wconversion" "--include=/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/generated-include/openssl/boringssl_prefix_symbols.h" "-DBORINGSSL_IMPLEMENTATION=1" "-DBORINGSSL_PREFIX=aws_lc_0_35_0" "-DAWSLC=1" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/x86_64-linux-gnu" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/generic-glibc" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/x86-linux-any" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/any-linux-any" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/x86_64-linux-gnu" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/generic-glibc" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/x86-linux-any" "-isystem=/opt/brazil-pkg-cache/packages/Zig/Zig-0.14.x.963.0/AL2_x86_64/DEV.STD.PTHREAD/build/lib/libc/include/any-linux-any" "-O0" "-Wp,-U_FORTIFY_SOURCE" "-o" "/local/p4clients/pkgbuild-const/workspace/src/RedactedInstallPhaseX86/build/private/cargo-target/x86_64-unknown-linux-gnu/release/build/aws-lc-sys-6f8254ecbfbdca56/out/8776f9bd49ec1cab-jitterentropy-gcd.o" "-c" "/local/p4clients/pkgbuild-const/workspace/build/RedactedInstallPhaseX86/RedactedInstallPhaseX86-0.2.103.0/AL2_x86_64/DEV.STD.PTHREAD/build/private/cargo-home/registry/src/-fb8d6763e87a159d/aws-lc-sys-0.35.0/aws-lc/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-gcd.c"cargo:warning=error: unsupported preprocessor arg: -U_FORTIFY_SOURCE 

[justsmth]

Hello! Yeah, we've got a backlog item to work on this.

As a workaround, I believe that exporting AWS_LC_SYS_NO_JITTER_ENTROPY=1 in the environment will avoid this failure. (Please let us know if it doesn't.) Thanks!

[Leandros]

Yes, the fix is working. Much appreciated!