From 5ae98abb2b38f457a6313d3817d85e7aa92dceea Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 10:43:39 +0100 Subject: [PATCH 01/14] fix: use direct artifact filenames without commit-sha in SageMaker workflow --- .github/workflows/smoke-tests-sagemaker.yaml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 6e070d4..560502b 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -16,7 +16,7 @@ jobs: GH_REF_NAME: ${{ github.ref_name }} SAGEMAKER_ARTIFACT_PREFIX: "code-editor-sagemaker-server" GH_TOKEN: ${{ github.token }} - AWS_REGION: us-east-2 + AWS_REGION: us-east-1 AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }} ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }} PROJECT_NAME: ${{ secrets.PROJECT_NAME }} @@ -48,7 +48,7 @@ jobs: ls -la FILES=( - "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" + "$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" ) # Check build artifact exists @@ -67,7 +67,7 @@ jobs: - name: Extract artifacts run: | - tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" + tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" - name: Build and push Docker image run: | @@ -100,7 +100,6 @@ jobs: docker rmi $ECR_REPOSITORY:$IMAGE_TAG $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$ECR_REPOSITORY:$IMAGE_TAG echo "Local Docker images cleaned up" rm -rf vscode-reh-web-linux-x64 - rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build echo "Local build artifacts cleaned up" - name: Configure SageMaker role AWS credentials @@ -290,7 +289,7 @@ jobs: ls -la FILES=( - "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" + "$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" ) # Check build artifact exists @@ -301,8 +300,7 @@ jobs: fi done - tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" - rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src + tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" - name: E2E testing @@ -340,7 +338,7 @@ jobs: exit 1 fi - DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-west-2.on.aws/projects/${PROJECT_ID}/compute?type=spaces" + DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-east-1.on.aws/projects/${PROJECT_ID}/compute?type=spaces" # Apply E2E testing patches From 3a3ef4336ab700108911ea3605c50e185875e889 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 10:43:39 +0100 Subject: [PATCH 02/14] fix: use direct artifact filenames without commit-sha in SageMaker workflow --- .github/workflows/smoke-tests-sagemaker.yaml | 24 ++++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 6e070d4..18f1760 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -16,7 +16,7 @@ jobs: GH_REF_NAME: ${{ github.ref_name }} SAGEMAKER_ARTIFACT_PREFIX: "code-editor-sagemaker-server" GH_TOKEN: ${{ github.token }} - AWS_REGION: us-east-2 + AWS_REGION: us-east-1 AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }} ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }} PROJECT_NAME: ${{ secrets.PROJECT_NAME }} @@ -39,16 +39,16 @@ jobs: with: node-version: '22' - - name: Download sagemaker build artifact by commit ID + - name: Download sagemaker build artifact run: | - gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-build" + gh run download --name "code-editor-sagemaker-server-build" - name: Check build artifacts exist run: | ls -la FILES=( - "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" + "$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" ) # Check build artifact exists @@ -67,7 +67,7 @@ jobs: - name: Extract artifacts run: | - tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build/$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" + tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-build.tar.gz" - name: Build and push Docker image run: | @@ -100,7 +100,7 @@ jobs: docker rmi $ECR_REPOSITORY:$IMAGE_TAG $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$ECR_REPOSITORY:$IMAGE_TAG echo "Local Docker images cleaned up" rm -rf vscode-reh-web-linux-x64 - rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-build + rm -rf $SAGEMAKER_ARTIFACT_PREFIX-build echo "Local build artifacts cleaned up" - name: Configure SageMaker role AWS credentials @@ -284,13 +284,13 @@ jobs: echo "Started SageMaker space: $SAGEMAKER_SPACE_NAME" - - name: Fetch source artifact by commit ID + - name: Fetch source artifact run: | - gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-src" + gh run download --name "code-editor-sagemaker-server-src" ls -la FILES=( - "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" + "$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" ) # Check build artifact exists @@ -301,8 +301,8 @@ jobs: fi done - tar -xzf "$COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src/$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" - rm -rf $COMMIT_SHA-$SAGEMAKER_ARTIFACT_PREFIX-src + tar -xzf "$SAGEMAKER_ARTIFACT_PREFIX-src.tar.gz" + rm -rf $SAGEMAKER_ARTIFACT_PREFIX-src - name: E2E testing @@ -340,7 +340,7 @@ jobs: exit 1 fi - DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-west-2.on.aws/projects/${PROJECT_ID}/compute?type=spaces" + DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-east-1.on.aws/projects/${PROJECT_ID}/compute?type=spaces" # Apply E2E testing patches From 6f19bb238812376e6506fe0366cfefc22893f52a Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 14:15:27 +0100 Subject: [PATCH 03/14] Fix: Fail workflow when smoke tests fail --- .github/workflows/smoke-tests-sagemaker.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index d337b83..3668b3b 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -358,6 +358,7 @@ jobs: cd smoke npm run compile npx playwright install + set -e SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless - name: Clean up SageMaker resources From 26459fd3791a918b6840ce44a6202603b3f72e65 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 14:34:10 +0100 Subject: [PATCH 04/14] fix: fail workflow when smoke tests fail --- .github/workflows/smoke-tests-sagemaker.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 3668b3b..29a79b3 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -358,8 +358,17 @@ jobs: cd smoke npm run compile npx playwright install - set -e + set +e SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless + TEST_EXIT_CODE=$? + set -e + + if [ $TEST_EXIT_CODE -ne 0 ]; then + echo "Smoke tests failed with exit code $TEST_EXIT_CODE" + exit $TEST_EXIT_CODE + fi + + echo "All smoke tests passed successfully" - name: Clean up SageMaker resources if: always() From b10faac2676491e8787e4c0ca78bf0abc201a4a0 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 14:34:10 +0100 Subject: [PATCH 05/14] fix: fail workflow when smoke tests fail --- .github/workflows/smoke-tests-sagemaker.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 3668b3b..9e89a84 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -358,8 +358,15 @@ jobs: cd smoke npm run compile npx playwright install - set -e - SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless + + SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log + + if grep -q "failing" test_output.log; then + echo "Smoke tests failed - detected failing tests in output" + exit 1 + fi + + echo "All smoke tests passed successfully" - name: Clean up SageMaker resources if: always() From 8db89c91eb296cc279b6880def1a75adfb2cbce5 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 10:43:39 +0100 Subject: [PATCH 06/14] fix: use direct artifact filenames without commit-sha in SageMaker workflow --- .github/workflows/smoke-tests-sagemaker.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index d337b83..18f1760 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -41,7 +41,7 @@ jobs: - name: Download sagemaker build artifact run: | - gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-build" + gh run download --name "code-editor-sagemaker-server-build" - name: Check build artifacts exist run: | @@ -286,7 +286,7 @@ jobs: - name: Fetch source artifact run: | - gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-src" + gh run download --name "code-editor-sagemaker-server-src" ls -la FILES=( From 4125a2f70fdd4723a133fadba0f26716f06e9e50 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 14:15:27 +0100 Subject: [PATCH 07/14] Fix: Fail workflow when smoke tests fail --- .github/workflows/smoke-tests-sagemaker.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 18f1760..1a74423 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -358,6 +358,7 @@ jobs: cd smoke npm run compile npx playwright install + set -e SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless - name: Clean up SageMaker resources From f80cc3ee9e3ecf1c98fa8785de604454c0742285 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Fri, 5 Dec 2025 14:34:10 +0100 Subject: [PATCH 08/14] fix: fail workflow when smoke tests fail --- .github/workflows/smoke-tests-sagemaker.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 1a74423..c1f2eb0 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -358,8 +358,15 @@ jobs: cd smoke npm run compile npx playwright install - set -e - SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless + + SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log + + if grep -q "failing" test_output.log; then + echo "Smoke tests failed - detected failing tests in output" + exit 1 + fi + + echo "All smoke tests passed successfully" - name: Clean up SageMaker resources if: always() From c92adfb19dfe129e9d75b3130198aeb6cb02f902 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 11:02:14 +0100 Subject: [PATCH 09/14] improve SageMaker smoke test workflow --- .github/workflows/smoke-tests-sagemaker.yaml | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index c1f2eb0..25ad97d 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -340,7 +340,7 @@ jobs: exit 1 fi - DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-east-1.on.aws/projects/${PROJECT_ID}/compute?type=spaces" + DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.${AWS_REGION}.on.aws/projects/${PROJECT_ID}/compute?type=spaces" # Apply E2E testing patches @@ -351,22 +351,8 @@ jobs: quilt push -a -f # Run smoke tests with DataZone authentication - cd test/smoke - npm i - cd .. - npm install mocha - cd smoke - npm run compile - npx playwright install - - SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log - - if grep -q "failing" test_output.log; then - echo "Smoke tests failed - detected failing tests in output" - exit 1 - fi - - echo "All smoke tests passed successfully" + npm install + SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run smoketest -- --web --headless - name: Clean up SageMaker resources if: always() From 17ece459b3bd0e14963c8fdd7be4a5abbd5a5871 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 11:02:14 +0100 Subject: [PATCH 10/14] improve SageMaker smoke test workflow --- .github/workflows/smoke-tests-sagemaker.yaml | 24 ++++---------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index c1f2eb0..c77c7f0 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -41,7 +41,7 @@ jobs: - name: Download sagemaker build artifact run: | - gh run download --name "code-editor-sagemaker-server-build" + gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-build" - name: Check build artifacts exist run: | @@ -286,7 +286,7 @@ jobs: - name: Fetch source artifact run: | - gh run download --name "code-editor-sagemaker-server-src" + gh run download --name "$COMMIT_SHA-code-editor-sagemaker-server-src" ls -la FILES=( @@ -340,7 +340,7 @@ jobs: exit 1 fi - DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.us-east-1.on.aws/projects/${PROJECT_ID}/compute?type=spaces" + DATAZONE_URL="https://${DATAZONE_DOMAIN_ID}.sagemaker.${AWS_REGION}.on.aws/projects/${PROJECT_ID}/compute?type=spaces" # Apply E2E testing patches @@ -351,22 +351,8 @@ jobs: quilt push -a -f # Run smoke tests with DataZone authentication - cd test/smoke - npm i - cd .. - npm install mocha - cd smoke - npm run compile - npx playwright install - - SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log - - if grep -q "failing" test_output.log; then - echo "Smoke tests failed - detected failing tests in output" - exit 1 - fi - - echo "All smoke tests passed successfully" + npm install + SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run smoketest -- --web --headless - name: Clean up SageMaker resources if: always() From 35e430b6598f8a7930f152063aaa8301f843fe6c Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 14:04:07 +0100 Subject: [PATCH 11/14] make it faster for testing --- .github/workflows/smoke-tests-sagemaker.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 656dc4b..32c7d25 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -2,6 +2,11 @@ name: Smoke Tests for SageMaker on: workflow_dispatch: + inputs: + commit_sha: + description: 'Commit SHA to use for artifacts' + required: false + type: string jobs: smoke-tests-sagemaker: @@ -12,7 +17,7 @@ jobs: id-token: write contents: read env: - COMMIT_SHA: ${{ github.sha }} + COMMIT_SHA: ${{ inputs.commit_sha || github.sha }} GH_REF_NAME: ${{ github.ref_name }} SAGEMAKER_ARTIFACT_PREFIX: "code-editor-sagemaker-server" GH_TOKEN: ${{ github.token }} From d6f0bf439d7bcae3c9d0ce1917863839b86377ae Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 14:29:11 +0100 Subject: [PATCH 12/14] 13 --- .github/workflows/smoke-tests-sagemaker.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 32c7d25..a150c5c 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -361,7 +361,6 @@ jobs: # Run smoke tests with DataZone authentication npm install - npm run compile npx playwright install SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run smoketest -- --web --headless From 56d33d7173ddf57a04ea7eb68cea4765c842c0cd Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 15:59:27 +0100 Subject: [PATCH 13/14] update --- .github/workflows/smoke-tests-sagemaker.yaml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 3d64444..4eeab45 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -2,11 +2,6 @@ name: Smoke Tests for SageMaker on: workflow_dispatch: - inputs: - commit_sha: - description: 'Commit SHA to use for artifacts' - required: false - type: string jobs: smoke-tests-sagemaker: @@ -17,7 +12,7 @@ jobs: id-token: write contents: read env: - COMMIT_SHA: ${{ inputs.commit_sha || github.sha }} + COMMIT_SHA: ${{ github.sha }} GH_REF_NAME: ${{ github.ref_name }} SAGEMAKER_ARTIFACT_PREFIX: "code-editor-sagemaker-server" GH_TOKEN: ${{ github.token }} @@ -356,6 +351,12 @@ jobs: quilt push -a -f # Run smoke tests with DataZone authentication + cd test/smoke + npm i + cd .. + npm install mocha + cd smoke + npm run compile npm install npx playwright install From 64b4c69348fe2e9566d0b16cc9d274106b5f4664 Mon Sep 17 00:00:00 2001 From: Feiyang Liu Date: Mon, 8 Dec 2025 16:01:40 +0100 Subject: [PATCH 14/14] update --- .github/workflows/smoke-tests-sagemaker.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/smoke-tests-sagemaker.yaml b/.github/workflows/smoke-tests-sagemaker.yaml index 4eeab45..d311b49 100644 --- a/.github/workflows/smoke-tests-sagemaker.yaml +++ b/.github/workflows/smoke-tests-sagemaker.yaml @@ -357,7 +357,6 @@ jobs: npm install mocha cd smoke npm run compile - npm install npx playwright install SSO_USERNAME="$SSO_USERNAME" SSO_PASSWORD="$SSO_PASSWORD" DATAZONE_URL="$DATAZONE_URL" SPACE_NAME="$SAGEMAKER_SPACE_NAME" VSCODE_REMOTE_SERVER_PATH="sagemaker" npm run mocha -- --web --headless 2>&1 | tee test_output.log