Please add typescript typings :)

[kristianmandrup]

Can be auto generated via tsconfig setting I believe :)

https://stackoverflow.com/questions/12687779/how-do-you-produce-a-d-ts-typings-definition-file-from-an-existing-javascript

npm install -g dts-gen
dts-gen -m <your-module>

[kristianmandrup]

Generated patchinko.d.ts file ;) via dts

/** Declaration file generated by dts-gen */

export function D(): void;

export function P(target: any, ...args: any[]): any;

export function PS(target: any, input: any, ...args: any[]): any;

export function S(closure: any): any;

export function constant(a: any, b: any, ...args: any[]): any;

export function immutable(a: any, b: any, ...args: any[]): any;

export namespace D {
    const prototype: {
    };

}

export namespace P {
    const prototype: {
    };

}

export namespace PS {
    const prototype: {
    };

}

export namespace S {
    const prototype: {
    };

}

export namespace constant {
    const prototype: {
    };

}

export namespace immutable {
    const prototype: {
    };

}

[barneycarroll]

Thanks @kristianmandrup! Sorry for my absence. I'll see about getting this integrated.

[jsamr]

@barneycarroll @kristianmandrup I have written more complete types with deep inference for my project. However, I have just tested with Typescript 3.1. If those fail for older versions, we could use your as default, and version redirect for mine.

[jsamr]

Here they are. You'll notice the spec files, where all the correct and incorrect examples from readme file are handled appropriately.

EDIT
PS1: We could use typings-checker for those specs
PS2: I would be OK to make a PR about it

[kristianmandrup]

Great! Well done :)

[barneycarroll]

@jsamr that would be great, thanks! I'd be very pleased to accept a PR on this.

[jsamr]

@kristianmandrup @barneycarroll

So, I took some time to rework this, stumbling on some errors of the draft I proposed. But the final outcome is, so far, very satisfying: #32. It would very appreciated if you took a look, and help with the review. You can start by taking a look at the types/patchinko/__tests__ folder and make sure they accurately follow patchinko API somehow complex rules.

Just git clone https://github.com/jsamr/patchinko.git and git checkout ts. If you want to test the types in your project (TS ⩾ 3.5), change patchinko version in your package.json as follow:

{
  "dependencies": {
    "patchinko": "github:jsamr/patchinko#ts"
  }
}