Skip to content

Comments

Add light haptic feedback to train info button#585

Merged
guytepper merged 1 commit intomainfrom
claude/add-haptic-info-button-dWemP
Feb 25, 2026
Merged

Add light haptic feedback to train info button#585
guytepper merged 1 commit intomainfrom
claude/add-haptic-info-button-dWemP

Conversation

@guytepper
Copy link
Member

Triggers impactLight haptic when tapping the info button in the route
details screen, consistent with other light interactions in the app.

https://claude.ai/code/session_01GvkRVotRTKiczQ1Mf8ZEvF

Triggers impactLight haptic when tapping the info button in the route
details screen, consistent with other light interactions in the app.

https://claude.ai/code/session_01GvkRVotRTKiczQ1Mf8ZEvF
@gemini-code-assist
Copy link

Summary of Changes

Hello @guytepper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience on the route details screen by introducing subtle haptic feedback. Tapping the train information button will now trigger a light haptic vibration, aligning the interaction with existing haptic patterns across the app and providing a more tactile response to user input.

Highlights

  • Haptic Feedback Integration: Implemented impactLight haptic feedback when the train information button is tapped on the route details screen.
  • User Experience Consistency: Ensured consistency with other light interaction haptics within the application, providing a more tactile response.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/screens/route-details/route-details-screen.tsx
    • Imported the react-native-haptic-feedback library.
    • Added HapticFeedback.trigger("impactLight") to the onPress handler of the train information button.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds haptic feedback to the train info button. The implementation is correct. I have one suggestion to improve performance and readability by using the useCallback hook for the event handler, which is a common React best practice.

Comment on lines +316 to +319
onPress={() => {
HapticFeedback.trigger("impactLight")
navigation.navigate("routeDetailsTrainInfo", { train: routeItem.trains[0] })
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better performance and to avoid creating a new function on every render, it's a good practice to memoize the onPress handler using React.useCallback. This also improves readability by extracting the logic from the JSX.

You can define the handler like this inside your component:

const handleTrainInfoPress = React.useCallback(() => {
  HapticFeedback.trigger("impactLight");
  navigation.navigate("routeDetailsTrainInfo", { train: routeItem.trains[0] });
}, [navigation, routeItem]);

Then, you can use it in the Pressable component:

<Pressable
  onPress={handleTrainInfoPress}
  // ... other props
>

@guytepper guytepper merged commit 4e173f6 into main Feb 25, 2026
3 of 4 checks passed
@guytepper guytepper deleted the claude/add-haptic-info-button-dWemP branch February 25, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants