Skip to content

Comments

Add PostHog event for opening train info sheet#586

Open
guytepper wants to merge 1 commit intomainfrom
claude/add-posthog-train-event-99F8s
Open

Add PostHog event for opening train info sheet#586
guytepper wants to merge 1 commit intomainfrom
claude/add-posthog-train-event-99F8s

Conversation

@guytepper
Copy link
Member

Track "train_info_sheet_opened" event when users tap the info button
to view train wagon details.

https://claude.ai/code/session_01KQi8o5KDVcdHQqZo5sAkLS

Track "train_info_sheet_opened" event when users tap the info button
to view train wagon details.

https://claude.ai/code/session_01KQi8o5KDVcdHQqZo5sAkLS
@gemini-code-assist
Copy link

Summary of Changes

Hello @guytepper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an analytics event to track user engagement with the train information feature. By recording when users open the train wagon details sheet, we can gain valuable insights into how often this functionality is utilized, which will help inform future development and improvements.

Highlights

  • Analytics Event Added: Implemented tracking for the "train_info_sheet_opened" event using PostHog when users tap the train information button.
  • User Interaction Tracking: The new event specifically captures when users access the train wagon details screen, providing insights into feature usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/screens/route-details/route-details-screen.tsx
    • Imported the trackEvent utility for analytics.
    • Added a call to trackEvent("train_info_sheet_opened") within the onPress handler of the train information button.
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an analytics event to track when the train info sheet is opened. The implementation is correct, but I've suggested an improvement to use constants for event names instead of raw strings to enhance maintainability and prevent typos. This is a common best practice for analytics tracking.

<Pressable
onPress={() => navigation.navigate("routeDetailsTrainInfo", { train: routeItem.trains[0] })}
onPress={() => {
trackEvent("train_info_sheet_opened")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and prevent typos, consider defining analytics event names as constants in a central location instead of using raw strings.

For example, you could create a constants file:

// app/services/analytics/events.ts
export const ANALYTICS_EVENTS = {
  TRAIN_INFO_SHEET_OPENED: "train_info_sheet_opened",
} as const;

And then use it in your component:

// app/screens/route-details/route-details-screen.tsx
import { ANALYTICS_EVENTS } from "../../services/analytics/events";
// ...
trackEvent(ANALYTICS_EVENTS.TRAIN_INFO_SHEET_OPENED);

This approach makes event names reusable, discoverable, and safer to use across the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants