Skip to content

Workaround SabreDAV's "funny" behaviour for contact sync #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tadzik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Workaround SabreDAV's "funny" behaviour for contact sync #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Net/CardDAVTalk.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,12 @@ sub SyncContactLinks {
# Missing properties return 404 status response, ignore

}
elsif ($Status =~ m/ 418 /) {
# Sabredav thinks it's funny to return 418 for missing entries.
# What they mean here is that this contact has since been removed.
# See https://github.com/sabre-io/dav/pull/734
push @Removed, $href;
}
else {
warn "ODD STATUS";
push @Errors, "Odd status in propstat response $href: $Status";
Expand Down