Skip to content

Extension points #37

@eiked

Description

@eiked

In my client code I need to obtain the barcode of a release.

I currently do (as of Discogs::Wrapper,v2)
barcode = release.identifiers && release.identifiers.find{|i|i.type=='Barcode'}
self.ean = barcode && barcode.value.strip

Back in Discogs::Wrapper,v1 I monkey patched Discogs::Release
so that release.barcode was available everywhere

First of all: the change to Hashie::Mash is very good!

But let's have the responses typed again, to enable extending again:
like
class Discogs::Release < Hashie::Mash

or maybe even introducing an extension point for all discogs responses like
Discogs::Release < Discogs::Response < Hashie::Mash

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions