feat: allow usage of custom border radius for animated fab#4591
Open
babucarr32 wants to merge 2 commits intocallstack:mainfrom
Open
feat: allow usage of custom border radius for animated fab#4591babucarr32 wants to merge 2 commits intocallstack:mainfrom
babucarr32 wants to merge 2 commits intocallstack:mainfrom
Conversation
|
Hey @babucarr32, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
Hi, it would be nice to enhance animated fab with option to change border radius. Can you merge this PR? |
Author
|
Alternative https://react-native-paper-abstracted.vercel.app |
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I was using the
AnimatedFABcomponent, But I wanted it'sborderRadiusto be completely round. But, when I applied theborderRadiusproperty on the style, it does not work. So, to fix that issue and allow the usage of customborderRadius, I came up with this feature.Test plan
Assign any number to
borderRadius, and it should work.