[BugFix - Severity HIGH] Hide modal through onDismiss callback#4592
Closed
mdaamir151 wants to merge 1 commit intocallstack:mainfrom
Closed
[BugFix - Severity HIGH] Hide modal through onDismiss callback#4592mdaamir151 wants to merge 1 commit intocallstack:mainfrom
mdaamir151 wants to merge 1 commit intocallstack:mainfrom
Conversation
mdaamir151
changed the title
|
Hey @mdaamir151, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
**Current behavior**: When user presses outside of modal, it gets dismissed internally regardless of whether app logic wants to close the modal and then user provided callback is invoked. This results in flicker - internal close and then immediate open due to `visible` state still `true` on modal if the app logic doesn't dismiss the modal immediately. Flicker is also caused if there are frame delays between user callback being invoked and `visible` state being set **New Behavior**: Initiate dismiss modal only when app logic sets `visible` state to false **Steps to reproduce bug**: Pass empty function as `onDismiss` callback and press outside of modal - modal flickers
Contributor
|
Hey @mdaamir151, while working on new-arch support this bug was taken into consideration. Could you verify if the bug still occurs in the latest release 5.13.1? |
Author
|
It's fixed in 5.13.1 |
Author
|
Resolved in 5.13.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior: When user presses outside of modal, it gets dismissed internally regardless of whether app logic wants to close the modal and then user provided callback is invoked. This results in flicker - internal close and then immediate open due to
visiblestate stilltrueon modal if the app logic doesn't dismiss the modal immediately. Flicker is also caused if there are frame delays between user callback being invoked andvisiblestate being setNew Behavior: Initiate dismiss modal only when app logic sets
visiblestate to falseSteps to reproduce bug: Pass empty function as
onDismisscallback and press outside of modal - modal flickersMotivation
Modal flickering on Android on close
modal_flicker_on_dismiss.mp4