fix(Lifecycle): don't cache the project (#892)

Author: lengau

craft_application/services/lifecycle.py

@@ -125,8 +125,6 @@ class LifecycleService(base.AppService):
         LifecycleManager on initialisation.
     """
 
-    _project: models.Project
-
     def __init__(
         self,
         app: AppMetadata,
@@ -145,11 +143,14 @@ def __init__(
     @override
     def setup(self) -> None:
         """Initialize the LifecycleManager with previously-set arguments."""
-        self._project = self._services.get("project").get()
         self._lcm = self._init_lifecycle_manager()
         callbacks.register_post_step(self.post_prime, step_list=[Step.PRIME])
         callbacks.register_configure_overlay(repositories.enable_overlay_eol)
 
+    @property
+    def _project(self) -> models.Project:
+        return self._services.get("project").get()
+
     def _get_build(self) -> craft_platforms.BuildInfo:
         """Get the build for this run."""
         plan = self._services.get("build_plan").plan()

docs/reference/changelog.rst

@@ -4,6 +4,15 @@
 Changelog
 *********
 
+5.9.1 (2025-09-04)
+------------------
+
+Services
+========
+
+- The Lifecycle Service no longer improperly caches the project (fixes ``adopt-info``).
+
+
 5.9.0 (2025-08-29)
 ------------------
 

tests/spread/testcraft/pack/bare-base/testcraft.yaml

@@ -1,5 +1,4 @@
 name: pack-bare-base
-version: "0.1"
 summary: Test packing with a bare base.
 
 base: bare
@@ -8,6 +7,12 @@ platforms:
   amd64:
     build-on: [amd64, arm64, ppc64el, s390x, riscv64]
 
+adopt-info: my-test  # Check that adopt-info works.
+
 parts:
   my-test:
     plugin: nil
+    override-pull: |
+      craftctl set version=1.2.3
+    override-build: |
+      craftctl get version | grep 1.2.3

tests/spread/testcraft/pack/task.yaml

@@ -9,5 +9,6 @@ execute: |
 
 restore: |
   cd "${PROJECT}"
+  test -f "pack-${PROJECT}-1.2.3-amd64.testcraft"
   rm -f *.testcraft
   testcraft clean

tests/spread/testcraft/unset-adopt-info/task.yaml

@@ -0,0 +1,11 @@
+summary: Check that testcraft fails with an unset adopt-info field
+
+systems:
+  - ubuntu-24.04-64
+
+environment:
+  CRAFT_BUILD_ENVIRONMENT/destructive: host
+  CRAFT_MANAGED_MODE/managed: 1
+
+execute: |
+  testcraft pack |& MATCH "Project field 'version' was not set."

tests/spread/testcraft/unset-adopt-info/testcraft.yaml

@@ -0,0 +1,13 @@
+name: unset-adopt-info
+summary: Test packing with adopt-info
+
+base: ubuntu@24.04
+platforms:
+  amd64:
+    build-on: [amd64, arm64, ppc64el, s390x, riscv64]
+
+adopt-info: my-test  # We need a version but don't supply it because we're evil!
+
+parts:
+  my-test:
+    plugin: nil

tests/unit/services/test_lifecycle.py

@@ -720,7 +720,7 @@ class LocalProject(models.Project):
         cache_dir=tmp_path / "cache",
         platform=None,
     )
-    service._project = fake_project
+    fake_services.get("project")._project_model = fake_project
     service._lcm = mock.MagicMock(spec=LifecycleManager)
     service._lcm.project_info = mock.MagicMock(spec=ProjectInfo)
     service._lcm.project_info.get_project_var = lambda _: "foo"