Skip to content

Commit afeeb72

Browse files
author
Sachin
committed
Remove unnecessary kconv dependency for Ruby 3.4 compatibility
- Remove require 'kconv' from winrm_base.rb - kconv was not actually used in the codebase and is not available as a standalone gem Signed-off-by: Sachin <sachin.jain@chef.io>
1 parent f8e3d7c commit afeeb72

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ else
1515
gem "knife"
1616
end
1717

18-
# gem "kconv" # Required for Ruby 3.4+ compatibility
19-
2018
group :test do
2119
gem "rspec", "~> 3.0"
2220
gem "rake"

knife-windows.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ Gem::Specification.new do |s|
1616
s.add_dependency "chef", ">= 18.2"
1717
s.add_dependency "chef-winrm", "~> 2.3"
1818
s.add_dependency "chef-winrm-elevated", "~> 1.2"
19-
# this needs to be uncommented when we release the gem
20-
s.add_dependency "kconv" # Required for Ruby 3.4+ compatibility
2119

2220
s.add_development_dependency "pry"
2321

lib/chef/knife/helpers/winrm_base.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ def self.included(includer)
3333

3434
deps do
3535
require "chef/encrypted_data_bag_item"
36-
require "kconv"
3736
require "readline"
3837
require "chef/json_compat"
3938
end

0 commit comments

Comments
 (0)