Skip to content

broken autobalancing logic in transactions containing notes #239

@akashpal-21

Description

@akashpal-21

In #223 a mechanism was added to allow posting notes. However, notes introduces atleast two regressions.

  1. It is not possible to simple supply one account which does not explicitly contain the balance.

Image

  1. It is possible to supply incorrect implicit balance

Image
Image

Expected behaviour

Case 1 is valid. Nanoledger should ignore presence of
; comment

Case 2 is invalid, ; comment is not an account

Requested fix

Do not include any entry starting with comment symbols in balancing requirement.

4.4 Commenting on your Journal
==============================

Comments are generally started using a ‘;’.  However, in order to
increase compatibility with other text manipulation programs and
methods, four additional comment characters are valid if used at the
beginning of a line: ‘#’, ‘|’, and ‘*’ and ‘%’.

   Block comments can be made by use ‘comment’ ...  ‘end comment’.

     ; This is a single line comment,
     #  and this,
     %   and this,
     |    and this,
     *     and this.

Sorry for presentation, posting from mobile.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions