From 22c25382a0368da2cf231e5ffa19fdc4ec0a9ea2 Mon Sep 17 00:00:00 2001 From: Dan Kordik Date: Fri, 5 Nov 2021 10:48:26 -0500 Subject: [PATCH 1/2] Update CONTRIBUTING so call out presentational components This could use more cleanup, but just trying to get Jira Github integration working with this particular update UF-86 #comment does this work? --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 78d24f68..cda9262d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,10 @@ # Contributing to RoverUI -## What to avoid in RoverUI +## Do + +RoverUI components should be Presentational building blocks. + +## Don't It's _not_ a repository for all shared components. Don't try to add components that deal specifically with business logic and concepts here. Don't try to add components that handle whole layout areas. This is a UI library only. From 18656095dd3298f696a4676ab8a94ef59f2b6b87 Mon Sep 17 00:00:00 2001 From: Dan Kordik Date: Fri, 5 Nov 2021 10:53:54 -0500 Subject: [PATCH 2/2] CONTRIBUTING.md - remove redundant component-writing guidelines [UF-86] how about brackets, Jira? does this work? #comment hello world --- CONTRIBUTING.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cda9262d..57eae3e3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,13 +1,5 @@ # Contributing to RoverUI -## Do - -RoverUI components should be Presentational building blocks. - -## Don't - -It's _not_ a repository for all shared components. Don't try to add components that deal specifically with business logic and concepts here. Don't try to add components that handle whole layout areas. This is a UI library only. - ## Run locally 1. Read the [Code Guidelines](./CODE_GUIDELINES.md)