The "NoCompression option" changes have broken automated updates for consumers

[aramprice]

The changes to CompressFilesInDir and CompressSpecificFilesInDir[1] in #129 has broken auto-updating in projects that consume bosh-utils.

For example usage of CompressFilesInDir by bosh-agent:

• https://github.com/cloudfoundry/bosh-agent/blob/main/agent/logstarprovider/logs_tar_provider.go#L67

	tarball, err := l.compressor.CompressFilesInDir(tmpDir, boshcmd.CompressorOptions{})
	if err != nil {
		return "", bosherr.WrapError(err, "Making logs tarball")
	}

means that the automated package bumping (go get -u) fails because the code in the bosh-agent is not compatible with this change.

Without manual intervention bosh-agent, and other projects will not have dependencies bumped.

[1] https://github.com/cloudfoundry/bosh-utils/pull/129/files#diff-f72f9c04b11cbd8afb8b43e7691207401ce4e03538675e86dc95af42b300a4ffR35-R45

[beyhan]

This bosh-agent issue should be addressed with cloudfoundry/bosh-agent#384. During the FI WG meeting yesterday the decision was taken to adapt the consumers.

[beyhan]

Also related cloudfoundry/bosh-cli#699

[aramprice]

Thanks that makes sense. Mostly wanted to make sure there was visibility since some of these pipelines aren't in the CFF concourse.

[beyhan]

Are the pipeline fixed now? Can we close this?

[aramprice]

At quick glance for the pipelines running internally there are at least two failures:

The pipeline for cloudfoundry/bosh-backup-and-restore is falling, after update[1], with:

factory/bosh_deployment_manager.go:7:10: could not import github.com/cloudfoundry/bosh-cli/v7/cmd/opts (vendor/github.com/cloudfoundry/bosh-cli/v7/cmd/opts/opts.go:10:10: could not import github.com/cloudfoundry/bosh-cli/v7/release (vendor/github.com/cloudfoundry/bosh-cli/v7/release/archive_reader.go:11:10: could not import github.com/cloudfoundry/bosh-cli/v7/release/job (vendor/github.com/cloudfoundry/bosh-cli/v7/release/job/archive_reader.go:13:2: could not import github.com/cloudfoundry/bosh-cli/v7/release/resource (-: # github.com/cloudfoundry/bosh-cli/v7/release/resource
vendor/github.com/cloudfoundry/bosh-cli/v7/release/resource/archive.go:93:54: not enough arguments in call to a.compressor.CompressFilesInDir
	have (string)
	want (string, fileutil.CompressorOptions))))) (typecheck)
	boshcmd "github.com/cloudfoundry/bosh-cli/v7/cmd/opts"

---

The pipeline for cloudfoundry/bosh-agent is falling, after update[1], with:

platform/net/fakes/fake_interface_manager.go:4:10: could not import github.com/cloudfoundry/bosh-agent/v2/platform/net (platform/net/firewall_provider_linux.go:14:2: could not import github.com/containerd/cgroups (-: # github.com/containerd/cgroups
vendor/github.com/containerd/cgroups/pids.go:51:53: invalid operation: resources.Pids.Limit > 0 (mismatched types *int64 and untyped int)
vendor/github.com/containerd/cgroups/pids.go:54:29: cannot use resources.Pids.Limit (variable of type *int64) as int64 value in argument to strconv.FormatInt)) (typecheck)
	boshnet "github.com/cloudfoundry/bosh-agent/v2/platform/net"
	        ^
platform/net/netfakes/fake_macaddress_detector.go:7:2: could not import github.com/cloudfoundry/bosh-agent/v2/platform/net (platform/net/firewall_provider_linux.go:14:2: could not import github.com/containerd/cgroups (-: # github.com/containerd/cgroups
vendor/github.com/containerd/cgroups/pids.go:51:53: invalid operation: resources.Pids.Limit > 0 (mismatched types *int64 and untyped int)
vendor/github.com/containerd/cgroups/pids.go:54:29: cannot use resources.Pids.Limit (variable of type *int64) as int64 value in argument to strconv.FormatInt)) (typecheck)
	"github.com/cloudfoundry/bosh-agent/v2/platform/net"
	^

---

[1] update commands:

go get -u ./... go@1.23.0 toolchain@go1.23.0
go get -u ./tools go@1.23.0 toolchain@go1.23.0
go mod tidy -go=1.23.0
go mod vendor

[aramprice]

There are still errors in the cloudfoundry/bosh-backup-and-restore pipeline:

factory/bosh_deployment_manager.go:7:10: could not import github.com/cloudfoundry/bosh-cli/v7/cmd/opts (vendor/github.com/cloudfoundry/bosh-cli/v7/cmd/opts/opts.go:10:10: could not import github.com/cloudfoundry/bosh-cli/v7/release (vendor/github.com/cloudfoundry/bosh-cli/v7/release/archive_reader.go:11:10: could not import github.com/cloudfoundry/bosh-cli/v7/release/job (vendor/github.com/cloudfoundry/bosh-cli/v7/release/job/archive_reader.go:13:2: could not import github.com/cloudfoundry/bosh-cli/v7/release/resource (-: # github.com/cloudfoundry/bosh-cli/v7/release/resource
vendor/github.com/cloudfoundry/bosh-cli/v7/release/resource/archive.go:93:54: not enough arguments in call to a.compressor.CompressFilesInDir
	have (string)
	want (string, fileutil.CompressorOptions))))) (typecheck)
	boshcmd "github.com/cloudfoundry/bosh-cli/v7/cmd/opts"
	        ^
1 issues:
* typecheck: 1
make: *** [Makefile:10: lint] Error 1

These may be related to cloudfoundry/bosh-agent's bump-deps job failing update it's dependencies (for reasons that appear unrelated):

golangci-lint has version 2.6.1 built with go1.24.2 from (unknown, modified: ?, mod sum: "h1:yTYVG6BJ4eG9QE815BAQDrC2xBbTB8lW11jg+YQ0b1c=") on (unknown)

 lint-ing with GOOS=windows...
0 issues.

 lint-ing with GOOS=linux...
platform/net/fakes/fake_interface_manager.go:4:10: could not import github.com/cloudfoundry/bosh-agent/v2/platform/net (platform/net/firewall_provider_linux.go:14:2: could not import github.com/containerd/cgroups (-: # github.com/containerd/cgroups
vendor/github.com/containerd/cgroups/pids.go:51:53: invalid operation: resources.Pids.Limit > 0 (mismatched types *int64 and untyped int)
vendor/github.com/containerd/cgroups/pids.go:54:29: cannot use resources.Pids.Limit (variable of type *int64) as int64 value in argument to strconv.FormatInt)) (typecheck)
	boshnet "github.com/cloudfoundry/bosh-agent/v2/platform/net"
	        ^
1 issues:
* typecheck: 1

[aramprice]

The bosh-agent pipeline is now bumping deps successfully 🎉

[aramprice]

cloudfoundry/bosh-backup-and-restore is updating now, as of the release of the bosh-cli v7.9.14