fix: ensure spa works with default indexFile of index.html

Author: brettz9

bin/cli.js

@@ -23,17 +23,20 @@ const dir = args.directory || '.';
 
 const log = function(request, response, statusCode) {
     const d = new Date();
+    /* c8 ignore next 3 -- Time-dependent */
     const seconds = d.getSeconds() < 10 ? '0' + d.getSeconds() : d.getSeconds(),
         minutes = d.getMinutes() < 10 ? '0' + d .getMinutes() : d.getMinutes(),
         hours   = d.getHours() < 10 ? '0' + d .getHours() : d.getHours(),
         datestr = hours + ':' + minutes + ':' + seconds,
 
         line = datestr + ' [' + response.statusCode + ']: ' + request.url;
     let colorized = line;
-    if (tty.isatty(process.stdout.fd))
+    /* c8 ignore next 5 -- Environment */
+    if (tty.isatty(process.stdout.fd)) {
         colorized = (response.statusCode >= 500) ? colors.red.bold(line) :
             (response.statusCode >= 400) ? colors.red(line) :
                 line;
+    }
     console.log(colorized);
 };
 
@@ -77,7 +80,7 @@ const server = http.createServer(function (request, response) {
         //   npm start -- --spa --index-file test/fixtures/there/index.html
         //   with http://127.0.0.1:8080/test/fixtures/there?email=john.cena
         if (args['spa'] && !new URL(request.url, 'http://localhost').pathname.includes(".")) {
-            file.serveFile(args['index-file'], 200, {}, request, response);
+            file.serveFile(args['index-file'] || 'index.html', 200, {}, request, response);
         } else {
             file.serve(request, response, callback);
         }
@@ -89,6 +92,7 @@ const hostAddress = args['host-address'] || '127.0.0.1';
 
 if (hostAddress === '127.0.0.1') {
     server.listen(port);
+/* c8 ignore next 3 -- Not working with localhost or 0.0.0.0 */
 } else {
     server.listen(port, hostAddress);
 }

test/integration/binary.js

@@ -136,6 +136,30 @@ describe('node-static (CLI)', function () {
             assert.equal(text, 'hello world', 'should respond with hello world');
         });
 
+        it('serving file within directory and spa and default indexFile', async function () {
+            const {response /* , stdout */} = await spawnConditional(binFile, [
+                fixturePath, '--spa'
+            ], timeout - 9000, {
+                condition: 'serving as a single page app',
+                error (err) {
+                    console.log('err', err);
+                },
+                action: (/* err, stdout */) => {
+                    return fetch(
+                        `http://localhost:8080/some/other/path`
+                    );
+                }
+            });
+
+            const {status} = response;
+            const contentType = response.headers.get('content-type');
+            // const text = await response.text();
+
+            assert.equal(status, 200, 'should respond with 200');
+            assert.equal(contentType, 'text/html', 'should respond with text/html');
+            // assert.contains(text, 'hello world', 'should respond with hello world');
+        });
+
         it('serving file within directory with headers', async function () {
             const {response /* , stdout */} = await spawnConditional(binFile, [
                 '-p', this.port,

test/integration/node-static-test.js

@@ -240,7 +240,7 @@ describe('node-static', function () {
                 method: 'HEAD'
             });
             assert.equal(response.status, 200, 'should respond with 200');
-            assert.isEmpty(await response.text(), 'head must has no body');
+            assert.isEmpty(await response.text(), 'head must have no body');
         });
 
         it('requesting headers', async function () {