Merged
Conversation
Contributor
Author
|
Actually, we do not even need FakeStructure anymore so this PR now removes it entirely |
Contributor
|
@cms-flaf-bot please test |
Collaborator
|
pipeline#13978141 started |
Collaborator
|
pipeline#13978141 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the past month (Konstantin's fault) the Fake Structure histograms have been broken. In PR 205 the
hist_list[0]was changed to 3 values instead of 2, but the FakeStructure version never added this third RDF variablehttps://github.com/cms-flaf/FLAF/pull/205/changes#diff-cb839516eb4b14295ac1b51b6d5475b3a0e580fc15d6565a88a36f1a22c20985
This PR puts a catch on this RDF (it was only needed for debug, so it is quite useless), as well as adds a 'fake' option to the UnitBin function so the multi-dimensional plots also can create fake structure.
This bug was unseen as it only exists for files that have 0 entries in a selection. I found this using QCD. In the future, maybe the robot should also include a QCD test for these types of bugs?