feat: pass JAVA_TOOL_OPTIONS to docker container#516
Closed
tkrop wants to merge 1 commit intocodacy:masterfrom
Closed
feat: pass JAVA_TOOL_OPTIONS to docker container#516tkrop wants to merge 1 commit intocodacy:masterfrom
tkrop wants to merge 1 commit intocodacy:masterfrom
Conversation
This change passes the JAVA_TOOL_OPTIONS to the docker container running the analysis. Doing this allows to setup a custom truststore that can successfully create SSL connections to a codacy-proxy. This allows to transparently authorize upload of results from a CI/CD system without storing Codacy tokens.
Author
|
We overlooked that we also need to mount the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change passes the JAVA_TOOL_OPTIONS to the docker container running the analysis. Doing this allows to setup a custom trust store that can successfully create SSL connections to a codacy-proxy. Using a codacy-proxy allows to transparently authorize upload of results from a CI/CD system without storing Codacy tokens.