Skip to content

Do not save user credentials in LocalStorage #131

@lorenzleutgeb

Description

@lorenzleutgeb

By merging this we now save the user password in LocalStorage. AFAIK we did not do that beforehand, anyway it is way less secure: Tokens expire automatically, a password does not. It also is prone to side-channel attacks on obtaining the user's password.

We should only save tokens, and we should only save them in an HTTP(S)-only cookie, that's why I implemented PUT /cookie earlier. We're stepping back in security hugely here.

CC: @victorbalan

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions