Please update dependencies

[scaronni]

Please update the code for sciplot and gattlib, it makes it difficult to package the project for distributions otherwise.

Current versions of sciplot and gattlib:

• sciplot 0.3.1
• gattlib 0.7.2

Thanks!

[scaronni]

libsurvive currently compiles with sciplot 0.2.2 and gattlib 0.4.13.

[bl4ckb0ne]

Are you encountering compilation issues with more recent versions? I see in the code that we don't require a version. What platform are you on, and could you give me your cmake generation command so I can reproduce locally please.

On master I can't even get the sciplot to build because of a missing Findsciplot.cmake file

[scaronni]

Hi, I'm taking care of the packaging for Fedora, so I'm trying to avoid to ship an old version of gattlib and an old version of sciplot just to build libsurvive.

I would say there's no specific command for this issue; just use any newer version than the ones in #330 (comment). but if you are interested, here is the SPEC file: https://src.fedoraproject.org/rpms/libsurvive/blob/rawhide/f/libsurvive.spec

And here you can see all the RPM macros expanded (cmake parameters, etc.). Note this is a build with compatible versions: https://kojipkgs.fedoraproject.org//packages/libsurvive/1.01%5E20250317git3e6edf1/2.fc42/data/logs/x86_64/build.log

Compilation fails in the following ways with the most recent gattlib and sciplot.

[scaronni]

gattlib:

libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:22:9: error: unknown type name ‘gatt_connection_t’; did you mean ‘gatt_connect_cb_t’?
   22 |         gatt_connection_t *gconn;
      |         ^~~~~~~~~~~~~~~~~
      |         gatt_connect_cb_t
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:56:32: error: unknown type name ‘gatt_connection_t’; did you mean ‘gatt_connect_cb_t’?
   56 | static uint32_t read_char_byte(gatt_connection_t *gatt_connection, uuid_t *uuid) {
      |                                ^~~~~~~~~~~~~~~~~
      |                                gatt_connect_cb_t
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:74:37: error: unknown type name ‘gatt_connection_t’; did you mean ‘gatt_connect_cb_t’?
   74 | static void ble_connect_device_done(gatt_connection_t *gatt_connection, void *arg) {
      |                                     ^~~~~~~~~~~~~~~~~
      |                                     gatt_connect_cb_t
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c: In function ‘ble_connect_device’:
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:139:9: error: unknown type name ‘gatt_connection_t’; did you mean ‘gatt_connect_cb_t’?
  139 |         gatt_connection_t *gatt_connection;
      |         ^~~~~~~~~~~~~~~~~
      |         gatt_connect_cb_t
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:142:27: error: implicit declaration of function ‘gattlib_connect_async’; did you mean ‘gattlib_connect’? [-Wimplicit-function-declaration]
  142 |         gatt_connection = gattlib_connect_async(connection->driver->adapter, addr, 0, ble_connect_device_done, connection);
      |                           ^~~~~~~~~~~~~~~~~~~~~
      |                           gattlib_connect
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:142:87: error: ‘ble_connect_device_done’ undeclared (first use in this function); did you mean ‘ble_connect_device’?
  142 |         gatt_connection = gattlib_connect_async(connection->driver->adapter, addr, 0, ble_connect_device_done, connection);
      |                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                       ble_connect_device
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:142:87: note: each undeclared identifier is reported only once for each function it appears in
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c: In function ‘gatt_thread’:
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:171:46: error: passing argument 2 of ‘gattlib_adapter_open’ from incompatible pointer type [-Wincompatible-pointer-types]
  171 |         int ret = gattlib_adapter_open(NULL, &driver->adapter);
      |                                              ^~~~~~~~~~~~~~~~
      |                                              |
      |                                              void **
In file included from libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:4:
/usr/include/gattlib.h:253:72: note: expected ‘gattlib_adapter_t **’ {aka ‘struct _gattlib_adapter **’} but argument is of type ‘void **’
  253 | int gattlib_adapter_open(const char* adapter_name, gattlib_adapter_t** adapter);
      |                                                    ~~~~~~~~~~~~~~~~~~~~^~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:178:60: error: passing argument 2 of ‘gattlib_adapter_scan_enable’ from incompatible pointer type [-Wincompatible-pointer-types]
  178 |         ret = gattlib_adapter_scan_enable(driver->adapter, ble_discovered_device, 1, driver);
      |                                                            ^~~~~~~~~~~~~~~~~~~~~
      |                                                            |
      |                                                            void (*)(void *, const char *, const char *, void *)
/usr/include/gattlib.h:274:89: note: expected ‘gattlib_discovered_device_t’ {aka ‘void (*)(struct _gattlib_adapter *, const char *, const char *, void *)’} but argument is of type ‘void (*)(void *, const char *, const char *, void *)’
  274 | int gattlib_adapter_scan_enable(gattlib_adapter_t* adapter, gattlib_discovered_device_t discovered_device_cb, size_t timeout, void *user_data);
      |                                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:151:13: note: ‘ble_discovered_device’ declared here
  151 | static void ble_discovered_device(void *adapter, const char *addr, const char *name, void *arg) {
      |             ^~~~~~~~~~~~~~~~~~~~~
/usr/include/gattlib.h:194:16: note: ‘gattlib_discovered_device_t’ declared here
  194 | typedef void (*gattlib_discovered_device_t)(gattlib_adapter_t* adapter, const char* addr, const char* name, void *user_data);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c: In function ‘gatt_close’:
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:199:82: error: passing argument 1 of ‘gattlib_write_char_by_uuid’ from incompatible pointer type [-Wincompatible-pointer-types]
  199 |                                         gattlib_write_char_by_uuid(driver->lhs[i]->gconn, power_uuid(), &powerdown[0], 1);
      |                                                                    ~~~~~~~~~~~~~~^~~~~~~
      |                                                                                  |
      |                                                                                  int *
/usr/include/gattlib.h:533:54: note: expected ‘gattlib_connection_t *’ {aka ‘struct _gattlib_connection *’} but argument is of type ‘int *’
  533 | int gattlib_write_char_by_uuid(gattlib_connection_t* connection, uuid_t* uuid, const void* buffer, size_t buffer_len);
      |                                ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:200:82: error: passing argument 1 of ‘gattlib_write_char_by_uuid’ from incompatible pointer type [-Wincompatible-pointer-types]
  200 |                                         gattlib_write_char_by_uuid(driver->lhs[i]->gconn, power_uuid(), &powerdown[1], 1);
      |                                                                    ~~~~~~~~~~~~~~^~~~~~~
      |                                                                                  |
      |                                                                                  int *
/usr/include/gattlib.h:533:54: note: expected ‘gattlib_connection_t *’ {aka ‘struct _gattlib_connection *’} but argument is of type ‘int *’
  533 | int gattlib_write_char_by_uuid(gattlib_connection_t* connection, uuid_t* uuid, const void* buffer, size_t buffer_len);
      |                                ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:201:74: error: passing argument 1 of ‘gattlib_disconnect’ from incompatible pointer type [-Wincompatible-pointer-types]
  201 |                                         gattlib_disconnect(driver->lhs[i]->gconn);
      |                                                            ~~~~~~~~~~~~~~^~~~~~~
      |                                                                          |
      |                                                                          int *
/usr/include/gattlib.h:385:46: note: expected ‘gattlib_connection_t *’ {aka ‘struct _gattlib_connection *’} but argument is of type ‘int *’
  385 | int gattlib_disconnect(gattlib_connection_t* connection, bool wait_disconnection);
      |                        ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/src/driver_gatt.c:201:41: error: too few arguments to function ‘gattlib_disconnect’; expected 2, have 1
  201 |                                         gattlib_disconnect(driver->lhs[i]->gconn);
      |                                         ^~~~~~~~~~~~~~~~~~
/usr/include/gattlib.h:385:5: note: declared here
  385 | int gattlib_disconnect(gattlib_connection_t* connection, bool wait_disconnection);
      |     ^~~~~~~~~~~~~~~~~~

[scaronni]

Relevant commit for gattlib: labapart/gattlib@ce52533

[scaronni]

sciplot, error is in cnkalman:

libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/../include/cnkalman/ModelPlot.h:16:23: error: cannot declare field ‘cnkalman::ModelPlot::plot’ to be of abstract type ‘sciplot::Plot’
   16 |         sciplot::Plot plot;
      |                       ^~~~
In file included from /usr/include/sciplot/Plot2D.hpp:37,
                 from /usr/include/sciplot/Figure.hpp:34,
                 from /usr/include/sciplot/Canvas.hpp:33,
                 from /usr/include/sciplot/sciplot.hpp:38,
                 from libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/../include/cnkalman/ModelPlot.h:6:
/usr/include/sciplot/Plot.hpp:56:7: note:   because the following virtual functions are pure within ‘sciplot::Plot’:
   56 | class Plot
      |       ^~~~
/usr/include/sciplot/Plot.hpp:204:18: note:     ‘virtual std::string sciplot::Plot::repr() const’
  204 |     virtual auto repr() const -> std::string = 0;
      |                  ^~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/../include/cnkalman/ModelPlot.h:17:23: error: cannot declare field ‘cnkalman::ModelPlot::map’ to be of abstract type ‘sciplot::Plot’
   17 |         sciplot::Plot map;
      |                       ^~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc: In destructor ‘cnkalman::ModelPlot::~ModelPlot()’:
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc:66:18: error: ‘class sciplot::Plot’ has no member named ‘show’
   66 |             plot.show();
      |                  ^~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc:67:17: error: ‘class sciplot::Plot’ has no member named ‘show’
   67 |             map.show();
      |                 ^~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc:69:14: error: ‘class sciplot::Plot’ has no member named ‘save’
   69 |         plot.save(name + "-plot.svg");
      |              ^~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc:70:13: error: ‘class sciplot::Plot’ has no member named ‘save’
   70 |         map.save(name + ".svg");
      |             ^~~~
libsurvive-8d4765a067ad2170f389a3d6226fe8bc555feb13/libs/cnkalman/src/ModelPlot.cc:71:13: error: ‘class sciplot::Plot’ has no member named ‘save’
   71 |         map.save(name + ".png");
      |             ^~~~

[scaronni]

Here I'm not sure exactly where the changes are, as the sciplot 0.2.2 version required by libsurvive it's almost 4 years old.

[scaronni]

btw, thanks for the latest commits about importing cnkalman, cnmatrix and dropping the python bindings, this has helped a lot in the packaging. Trying to compile all of it before as shared libraries has been quite a challenge.

[bl4ckb0ne]

No idea why I can't reproduce on debian Trixie, but I booted an archlinux container and can see what you are reporting. I'll prepare a patch.

btw, thanks for the latest commits about importing cnkalman, cnmatrix and dropping the python bindings, this has helped a lot in the packaging. Trying to compile all of it before as shared libraries has been quite a challenge.

Yes that's very recent, I want to rework the build files a bit before tagging a release.

[bl4ckb0ne]

I opened #331, took care of sciplot (0.3.1) already, i'll do gattlib later.