From 7a54d8b36df287a955b70ab14236eea51f4d5526 Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Sat, 9 May 2020 21:42:41 +0100 Subject: [PATCH 01/14] Update getConfigTreeBuilder for forward-compatibility #123 --- DependencyInjection/Configuration.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php index 52ef5e4a..379ba0cc 100644 --- a/DependencyInjection/Configuration.php +++ b/DependencyInjection/Configuration.php @@ -17,8 +17,10 @@ class Configuration implements ConfigurationInterface */ public function getConfigTreeBuilder() { - $treeBuilder = new TreeBuilder(); - $rootNode = $treeBuilder->root('comur_image'); + $treeBuilder = new TreeBuilder('comur_image'); + $rootNode = method_exists($treeBuilder, "getRootNode") + ? $treeBuilder->getRootNode() + : $treeBuilder->root('comur_image'); // BC layer for symfony/config 4.2 and older $rootNode ->children() From 9563cd0edebc83d1b367b7d466e516b097bab13e Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Sun, 10 May 2020 13:21:15 +0100 Subject: [PATCH 02/14] Replace deprecated spaceless tag with apply Minimum twig version increased to match Symfony 3.4 and ensure the apply tag is available --- Resources/views/Form/fields.html.twig | 8 ++++---- composer.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Resources/views/Form/fields.html.twig b/Resources/views/Form/fields.html.twig index 140c84f9..a14ca437 100644 --- a/Resources/views/Form/fields.html.twig +++ b/Resources/views/Form/fields.html.twig @@ -1,7 +1,7 @@ {% block comur_image_widget %} {% trans_default_domain comur_translation_domain %} {# trans_default_domain 'ComurImageBundle' #} - {% spaceless %} + {% apply spaceless %} {# block('form_widget_simple') #} {{ form_widget(form[name])}} {% if options.uploadConfig.saveOriginal %} @@ -35,7 +35,7 @@ - {% endspaceless %} + {% endapply %}