[5.x]: Editability conditions on matrix fields are overriding conditions in nested elements

[membla]

What happened?

Description

Editability conditions on matrix fields are setting edibility for fields in nested elements. This seem counterintuitive and inconsistent to me - I believe it should only affect the edibility of the actual Matrix field.

The way it is set up now overrides any Editability conditions on fields in nested entries.

Steps to reproduce

1. Create a matrix field
2. Set Editability conditions on the matrix field
3. Add an element that itself has fields with Editability conditions to the matrix field

Expected behavior

The Editability conditions of the fields in the entry added should be respected.

Actual behavior

All fields contained in the Matrix field are non-editable if Editability conditions make the matrix field non-editable.

Craft CMS version

5.9.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear]

CMS-1795

[brandonkelly]

The current behavior is due to limitations on the field API – Matrix is being told to render its input statically (non-editable). It doesn’t know whether that’s because it’s for a revision (where nested fields should definitely not be editable), or due to an editability condition (where this might be debatable). So for now, there’s not really anything we can do here. We’ll discuss whether it makes sense to reevaluate for Craft 6, though.