Install editable hloc to deps rather than src. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

B1ueber2y merged 5 commits into main from fix/editable_install

Dec 11, 2025

.github/workflows/build.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -70,14 +70,21 @@ jobs: @@
             with:
               python-version: ${{ matrix.config.python-version  }}
+          - name: Free disk space
+            run: |
+              sudo rm -rf /usr/share/dotnet
+              sudo rm -rf /usr/local/lib/android
+              sudo rm -rf /opt/ghc
+              docker system prune -af || true
           - name: Clean workspace artifacts
             run: rm -rf build/ dist/ *.egg-info/ .eggs/
           - name: Install Python dependencies
             run: |
               git submodule update --init --recursive
               python -m pip install --upgrade pip
-              python -m pip install -r requirements.txt
+              python -m pip install --src deps -r requirements.txt
           - name: Build
             run:  python -m pip install -v .
@@ Expand Down @@

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ @@
     /dist/
     cmake-build-*
     *.egg-info/
-    src/hloc
+    deps/
     *.npy
     *.png
@@ Expand Down @@

README.md

-Original file line number
+Diff line change
@@ Expand Up @@
     To install the LIMAP Python package:
     ```
     git submodule update --init --recursive
-    python -m pip install -r requirements.txt
+    python -m pip install --src deps -r requirements.txt
     python -m pip install -Ive .
     ```
     To double check if the package is successfully installed:
@@ Expand Down @@

cmake/FindDependencies.cmake

-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ endif() @@
     find_package(Boost REQUIRED COMPONENTS
                  graph
                  program_options
+                 OPTIONAL_COMPONENTS
                  system)
     # Ceres
@@ Expand Down @@

Provide feedback