-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
Description
Thanks for all you've done. Thats great to support what other people like and use.
Let me notice that project codebase is rather old and should be updated to use with iOS 7.
I'll point out main issues:
- Opaque status bar (iOS 7) is drawn on top of browser's navigationBar when it is on top in its hidden state. What could be done to solve this issue is fading contents of navigationBar while scrolling. But it's not an easy task, because default navigation bar items could not be faded and that's why they should be customized (including back button).
- Current implementation of fading on scrolling is... ok, but i'm not happy with it. It was made in order to become reusable, but it's not covering all the edge cases and is not easy to understand. So i suppose it's better to reimplement 'hiding on scrolling' inside the web browser view controller and throw away DZScrollingInspector.
- Introduce XIB customization. Everybody use IB nowadays but TSMiniWebBrowser codebase is far from it. Actually i assumed that it's easier to rewrite the whole thing around XIB than modify existing solution.
- Sharing the URL is a bit strange. It's action sheet before activity view controller. It was suitable for iOS 6 but now it's something strange. It's better to be activity view controller with some kind of application activities, for example: open in safari, open in chrome, open in pocket e.t.c. The more activities you have the better every app which uses this browser controller become. In my opinion more sharing activities is always good thing.