Skip to content

Suggestion: move core-kernel dependency to devDependencies #14

@e-m-s-y

Description

@e-m-s-y

Hey rsk,

I noticed that @arkecosystem/core-kernel is in your dependency list -> https://github.com/deadlock-delegate/notifier/blob/master/package.json#L35

I think this will break your plugin when running it on relay with core version > next.35. In this case your plugin will use a different version of core-kernel rather than the actual one the relay uses, however I'm not 100% sure on this. My suggestion is to move core-kernel to your devDependencies instead. I had similar issues with this in the past and now that next.36 is released it might be worth looking into.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions