Renamed test files, Fixed transpiler bugs

Author: deepentropy

indicators/index.ts

@@ -3,15 +3,15 @@
  * Collects inputs, types, methods, and other metadata
  */
 
-import type { ASTNode } from '../PineParser.js';
-import type { 
-  InputDefinition, 
-  TypeInfo, 
-  MethodInfo, 
-  FieldInfo, 
-  ImportInfo, 
-  LibraryInfo,
-  TranspileWarning
+import type {ASTNode} from '../PineParser.js';
+import type {
+    FieldInfo,
+    ImportInfo,
+    InputDefinition,
+    LibraryInfo,
+    MethodInfo,
+    TranspileWarning,
+    TypeInfo
 } from '../types.js';
 
 /**
@@ -82,6 +82,15 @@ export class InfoCollector {
       this.collectReassignmentInfo(node);
     }
 
+      // Handle compound assignments (+=, -=, *=, /=) which are parsed as BinaryExpression
+      // but semantically behave like reassignments
+      if (node.type === 'BinaryExpression') {
+          const op = String(node.value || '');
+          if (['+=', '-=', '*=', '/='].includes(op)) {
+              this.collectReassignmentInfo(node);
+          }
+      }
+
     if (node.type === 'MemberExpression') {
       this.collectMemberExpressionInfo(node);
     }

indicators/obv/obv.ts

@@ -2,15 +2,15 @@
  * Expression generation logic
  */
 
-import type { ASTNode } from '../PineParser.js';
-import type { GeneratorContext, MethodInfo, PlotConfig } from '../types.js';
-import { 
-  translateFunctionName, 
-  translateIdentifier, 
-  translateMemberExpression,
-  getColorValue
+import type {ASTNode} from '../PineParser.js';
+import type {GeneratorContext} from '../types.js';
+import {
+    getColorValue,
+    translateFunctionName,
+    translateIdentifier,
+    translateMemberExpression
 } from '../mappers/index.js';
-import { INDENT_SIZE } from '../utils/index.js';
+import {INDENT_SIZE} from '../utils/index.js';
 
 /**
  * Generates TypeScript code for PineScript expressions
@@ -542,6 +542,11 @@ export class ExpressionGenerator {
       return `ta.vwma(${args}, volume)`;
     }
 
+      // Handle runtime.error - throw an error with the given message
+      if (name === 'runtime.error') {
+          return `(() => { throw new Error(${args}); })()`;
+      }
+
     // Translate common function names
     const translated = translateFunctionName(name);
     return `${translated}(${args})`;

packages/pine2ts/src/transpiler/collectors/InfoCollector.ts

@@ -2,11 +2,11 @@
  * Statement generation logic
  */
 
-import type { ASTNode } from '../PineParser.js';
-import type { GeneratorContext } from '../types.js';
-import { ExpressionGenerator } from './ExpressionGenerator.js';
-import { sanitizeIdentifier, applyIndent, INDENT_SIZE } from '../utils/index.js';
-import { translateFunctionName, translateIdentifier } from '../mappers/index.js';
+import type {ASTNode} from '../PineParser.js';
+import type {GeneratorContext} from '../types.js';
+import {ExpressionGenerator} from './ExpressionGenerator.js';
+import {applyIndent, INDENT_SIZE, sanitizeIdentifier} from '../utils/index.js';
+import {translateFunctionName, translateIdentifier} from '../mappers/index.js';
 
 /**
  * Generates TypeScript code for PineScript statements
@@ -160,9 +160,12 @@ export class StatementGenerator {
     const tsName = sanitizeIdentifier(name);
     this.context.variables.set(name, tsName);
 
+      // Use 'let' if this variable will be reassigned (including compound assignments like +=)
+      const declKeyword = this.context.reassignedVariables.has(name) ? 'let' : 'const';
+
     if (node.children && node.children.length > 0) {
       const init = this.expressionGen.generateExpression(node.children[0]!);
-      this.emit(`const ${tsName} = ${init};`);
+        this.emit(`${declKeyword} ${tsName} = ${init};`);
     } else {
       this.emit(`let ${tsName};`);
     }

packages/pine2ts/src/transpiler/generators/ExpressionGenerator.ts

@@ -2,7 +2,7 @@
  * Identifier mapping utilities for PineScript to TypeScript
  */
 
-import { sanitizeIdentifier } from '../utils/index.js';
+import {sanitizeIdentifier} from '../utils/index.js';
 
 /**
  * Translate PineScript identifiers to TypeScript equivalents
@@ -44,13 +44,20 @@ export function translateMemberExpression(name: string): string {
   }
 
   // Handle barstate variables
+    // Note: In batch mode (processing all bars at once), barstate variables have fixed values:
+    // - isfirst: false (we've processed past the first bar)
+    // - islast: true (we're at the end of available data)
+    // - isconfirmed: true (all historical bars are confirmed)
+    // - islastconfirmedhistory: true (same as islast for historical data)
+    // - isrealtime: false (we're processing historical data)
+    // - isnew: false (not in a real-time streaming context)
   const barstateMap: Record<string, string> = {
-    'barstate.isfirst': '(i === 0)',
-    'barstate.islast': '(i === bars.length - 1)',
+      'barstate.isfirst': 'false',
+      'barstate.islast': 'true',
     'barstate.isconfirmed': 'true',
-    'barstate.islastconfirmedhistory': '(i === bars.length - 1)',
+      'barstate.islastconfirmedhistory': 'true',
     'barstate.isrealtime': 'false',
-    'barstate.isnew': 'true',
+      'barstate.isnew': 'false',
   };
 
   if (barstateMap[name]) {

packages/pine2ts/src/transpiler/generators/StatementGenerator.ts

@@ -1,8 +1,8 @@
-import { describe, it, expect } from 'vitest';
-import { PineParser } from '../src/transpiler/PineParser';
-import { transpile } from '../src/transpiler/PineToTS';
+import {describe, expect, it} from 'vitest';
+import {PineParser} from '../src/transpiler/PineParser';
+import {transpile} from '../src/transpiler/PineToTS';
 
-describe('Phase 1: Core Language Features', () => {
+describe('Control Flow and Operators', () => {
   describe('Reassignment Operator `:=`', () => {
     it('should parse `:=` reassignment', () => {
       const parser = new PineParser();
@@ -19,8 +19,8 @@ var counter = 0
 counter := counter + 1`;
 
       const result = transpile(source);
-      
-      expect(result).toContain('const counter = 0');
+
+        expect(result).toContain('let counter = 0');  // 'let' because counter is reassigned with :=
       expect(result).toContain('counter = (counter + 1)');  // Expression has parentheses
     });
   });

packages/pine2ts/src/transpiler/mappers/IdentifierMapper.ts

@@ -1,8 +1,8 @@
-import { describe, it, expect } from 'vitest';
-import { PineParser } from '../src/transpiler/PineParser';
-import { transpile } from '../src/transpiler/PineToTS';
+import {describe, expect, it} from 'vitest';
+import {PineParser} from '../src/transpiler/PineParser';
+import {transpile} from '../src/transpiler/PineToTS';
 
-describe('Phase 2: Input System & Built-in Variables', () => {
+describe('Inputs and Built-in Variables', () => {
   describe('Input Functions', () => {
     describe('input.int()', () => {
       it('should parse input.int with positional args', () => {
@@ -42,7 +42,7 @@ length = input.int(14, "Length")`;
 
         const result = transpile(source);
 
-        expect(result).toContain('inputs: Partial<IndicatorInputs> = {}');
+        expect(result).toContain('Partial<IndicatorInputs> = {}');
         expect(result).toContain('{ length } = { ...defaultInputs, ...inputs }');
       });
     });
@@ -211,24 +211,26 @@ position = bar_index`;
       expect(result).toContain('= i');
     });
 
-    it('should translate barstate.isfirst', () => {
+      it('should translate barstate.isfirst to false in batch mode', () => {
       const source = `indicator("Test")
 if barstate.isfirst
     x = 1`;
-      
+
       const result = transpile(source);
-      
-      expect(result).toContain('(i === 0)');
+
+          // In batch mode, barstate.isfirst is always false (we've processed past the first bar)
+          expect(result).toContain('if (false)');
     });
 
-    it('should translate barstate.islast', () => {
+      it('should translate barstate.islast to true in batch mode', () => {
       const source = `indicator("Test")
 if barstate.islast
     x = 1`;
-      
+
       const result = transpile(source);
-      
-      expect(result).toContain('(i === bars.length - 1)');
+
+          // In batch mode, barstate.islast is always true (we're at the end of available data)
+          expect(result).toContain('if (true)');
     });
   });
 
@@ -372,10 +374,11 @@ if barstate.isfirst
     firstClose := close
 
 plot(firstClose)`;
-      
-      const result = transpile(source);
-      
-      expect(result).toContain('if ((i === 0))');
+
+        const result = transpile(source);
+
+        // In batch mode, barstate.isfirst is false (we've processed past the first bar)
+        expect(result).toContain('if (false)');
       expect(result).toContain('firstClose = close');
     });
 

…/pine2ts/tests/transpiler-phase1.test.ts …kages/pine2ts/tests/control-flow.test.tspackages/pine2ts/tests/transpiler-phase1.test.ts renamed to packages/pine2ts/tests/control-flow.test.ts packages/pine2ts/tests/transpiler-phase1.test.ts renamed to packages/pine2ts/tests/control-flow.test.ts

@@ -1,9 +1,9 @@
-import { describe, it, expect } from 'vitest';
-import { PineParser } from '../src/transpiler/PineParser';
-import { transpile } from '../src/transpiler/PineToTS';
-import { LibraryResolver, FileSystemInterface } from '../src/transpiler/LibraryResolver';
+import {describe, expect, it} from 'vitest';
+import {PineParser} from '../src/transpiler/PineParser';
+import {transpile} from '../src/transpiler/PineToTS';
+import {FileSystemInterface, LibraryResolver} from '../src/transpiler/LibraryResolver';
 
-describe('Phase 4: Library Import System', () => {
+describe('Library Import System', () => {
   describe('Import Statement Parsing', () => {
     describe('Basic import parsing', () => {
       it('should parse import statement with alias', () => {

…/pine2ts/tests/transpiler-phase2.test.ts …ine2ts/tests/inputs-and-builtins.test.tspackages/pine2ts/tests/transpiler-phase2.test.ts renamed to packages/pine2ts/tests/inputs-and-builtins.test.ts packages/pine2ts/tests/transpiler-phase2.test.ts renamed to packages/pine2ts/tests/inputs-and-builtins.test.ts

@@ -1,8 +1,8 @@
-import { describe, it, expect } from 'vitest';
-import { PineParser } from '../src/transpiler/PineParser';
-import { transpile } from '../src/transpiler/PineToTS';
+import {describe, expect, it} from 'vitest';
+import {PineParser} from '../src/transpiler/PineParser';
+import {transpile} from '../src/transpiler/PineToTS';
 
-describe('Phase 3: User-Defined Types and Methods', () => {
+describe('User-Defined Types and Methods', () => {
   describe('Type Declarations', () => {
     describe('Basic type parsing', () => {
       it('should parse simple type declaration', () => {