Skip to content

Commit 86fbe48

Browse files
committed
[Cli] resolve domain list display errors
1 parent 8c9ebb8 commit 86fbe48

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

cli/ctl/domain.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,17 +126,21 @@ func listDomain(cmd *cobra.Command, args []string, output string) {
126126
fmt.Printf(string(yData))
127127
} else {
128128
nameMaxSize := len("NAME")
129-
129+
idMaxSize := len("ID")
130130
for i := range response.Get("DATA").MustArray() {
131131
d := response.Get("DATA").GetIndex(i)
132132
nameSize := len(d.Get("NAME").MustString())
133133
if nameSize > nameMaxSize {
134134
nameMaxSize = nameSize
135135
}
136+
idSize := len(d.Get("CLUSTER_ID").MustString())
137+
if idSize > idMaxSize {
138+
idMaxSize = idSize
139+
}
136140
}
137-
format := "%-*s %-14s %-37s %-17s %-15s %-22s %-22s %-8s %-10s %s\n"
141+
format := "%-*s %-*s %-37s %-17s %-15s %-22s %-22s %-8s %-10s %s\n"
138142
header := fmt.Sprintf(
139-
format, nameMaxSize, "NAME", "ID", "LCUUID", "TYPE", "CONTROLLER_IP",
143+
format, nameMaxSize, "NAME", idMaxSize, "ID", "LCUUID", "TYPE", "CONTROLLER_IP",
140144
"CREATED_AT", "SYNCED_AT", "ENABLED", "STATE", "AGENT_WATCH_K8S", // TODO translate state to readable word
141145
)
142146
fmt.Fprint(os.Stderr, header)
@@ -150,7 +154,7 @@ func listDomain(cmd *cobra.Command, args []string, output string) {
150154
}
151155
}
152156
fmt.Printf(
153-
format, nameMaxSize-nameChineseCount, name, d.Get("CLUSTER_ID").MustString(), d.Get("LCUUID").MustString(),
157+
format, nameMaxSize-nameChineseCount, name, idMaxSize, d.Get("CLUSTER_ID").MustString(), d.Get("LCUUID").MustString(),
154158
common.DomainType(d.Get("TYPE").MustInt()), d.Get("CONTROLLER_IP").MustString(),
155159
d.Get("CREATED_AT").MustString(), d.Get("SYNCED_AT").MustString(),
156160
common.DomainEnabled(d.Get("ENABLED").MustInt()), common.DomainState(d.Get("STATE").MustInt()),

cli/ctl/sub_domain.go

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,25 @@ func listSubDomain(cmd *cobra.Command, args []string, output string) error {
165165
domainNameMaxSize, "DOMAIN_NAME", domainMaxSize, "DOMAIN")
166166
for i := range response.Get("DATA").MustArray() {
167167
sb := response.Get("DATA").GetIndex(i)
168+
name := sb.Get("NAME").MustString()
169+
var nameChineseCount int
170+
for _, b := range name {
171+
if common.IsChineseChar(string(b)) {
172+
nameChineseCount += 1
173+
}
174+
}
175+
dName := sb.Get("DOMAIN_NAME").MustString()
176+
var dNameChineseCount int
177+
for _, d := range dName {
178+
if common.IsChineseChar(string(d)) {
179+
dNameChineseCount += 1
180+
}
181+
}
168182
fmt.Printf(cmdFormat,
169-
nameMaxSize, sb.Get("NAME").MustString(),
183+
nameMaxSize-nameChineseCount, name,
170184
clusterIDMaxSize, sb.Get("CLUSTER_ID").MustString(),
171185
lcuuidMaxSize, sb.Get("LCUUID").MustString(),
172-
domainNameMaxSize, sb.Get("DOMAIN_NAME").MustString(),
186+
domainNameMaxSize-dNameChineseCount, dName,
173187
domainMaxSize, sb.Get("DOMAIN").MustString())
174188
}
175189
return nil

0 commit comments

Comments
 (0)