[controller] fix bug - health check api should check response if null

SongZhen0704 · sharang · commit ae1e9018076b · 2022-09-12T22:31:28.000+08:00
diff --git a/server/controller/monitor/common.go b/server/controller/monitor/common.go
@@ -47,6 +47,8 @@ func isActive(urlPrefix string, ip string, port int) bool {
 	} else if response.StatusCode != http.StatusOK {
 		log.Warning("curl (%s) failed, (%d)", url, response.StatusCode)
 	}
-	defer response.Body.Close()
+	if response != nil && response.Body != nil {
+		response.Body.Close()
+	}
 	return err == nil && response.StatusCode == http.StatusOK
 }

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ func isActive(urlPrefix string, ip string, port int) bool {`
`47`	`47`	`} else if response.StatusCode != http.StatusOK {`
`48`	`48`	`log.Warning("curl (%s) failed, (%d)", url, response.StatusCode)`
`49`	`49`	`}`
`50`		`- defer response.Body.Close()`
	`50`	`+ if response != nil && response.Body != nil {`
	`51`	`+ response.Body.Close()`
	`52`	`+ }`
`51`	`53`	`return err == nil && response.StatusCode == http.StatusOK`
`52`	`54`	`}`