From a7d830e26abca70b9b64d8cc8a06eea28c935a29 Mon Sep 17 00:00:00 2001 From: Christoffer Artmann Date: Mon, 15 Dec 2025 16:00:50 +0100 Subject: [PATCH 1/2] fix: Keep the dataframe in view when you reduce its size. --- .../extension-side/dataframe/dataframeController.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/webviews/extension-side/dataframe/dataframeController.ts b/src/webviews/extension-side/dataframe/dataframeController.ts index b6ba2c640..69c7170f4 100644 --- a/src/webviews/extension-side/dataframe/dataframeController.ts +++ b/src/webviews/extension-side/dataframe/dataframeController.ts @@ -4,6 +4,8 @@ import { env, l10n, NotebookEdit, + NotebookEditorRevealType, + NotebookRange, type NotebookCellOutput, type NotebookEditor, type NotebookRendererMessaging, @@ -293,6 +295,11 @@ export class DataframeController implements IExtensionSyncActivationService { ranges: [{ start: cellIndex, end: cellIndex + 1 }], document: editor.notebook.uri }); + + // Reveal the cell to keep it visible after output size changes + const notebookRange = new NotebookRange(cellIndex, cellIndex + 1); + + editor.revealRange(notebookRange, NotebookEditorRevealType.InCenterIfOutsideViewport); } private async handleSelectPageSize(editor: NotebookEditor, message: SelectPageSizeCommand) { @@ -342,6 +349,11 @@ export class DataframeController implements IExtensionSyncActivationService { ranges: [{ start: cellIndex, end: cellIndex + 1 }], document: editor.notebook.uri }); + + // Reveal the cell to keep it visible after output size changes + const notebookRange = new NotebookRange(cellIndex, cellIndex + 1); + + editor.revealRange(notebookRange, NotebookEditorRevealType.InCenterIfOutsideViewport); } private async onDidReceiveMessage( From 84a86665990d7d541b5aa7d6b50d7a8deebeb56f Mon Sep 17 00:00:00 2001 From: Christoffer Artmann Date: Thu, 18 Dec 2025 13:13:47 +0100 Subject: [PATCH 2/2] update types --- src/test/datascience/mockQuickPick.ts | 1 + src/test/datascience/notebook/helper.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/test/datascience/mockQuickPick.ts b/src/test/datascience/mockQuickPick.ts index 6129de31d..a5dbf495c 100644 --- a/src/test/datascience/mockQuickPick.ts +++ b/src/test/datascience/mockQuickPick.ts @@ -6,6 +6,7 @@ import { Event, EventEmitter, QuickInputButton, QuickPick, QuickPickItem, QuickP export class MockQuickPick implements QuickPick { public value: string = ''; public placeholder: string | undefined; + public prompt: string | undefined; public title: string | undefined = 'foo'; public step: number | undefined; public totalSteps: number | undefined; diff --git a/src/test/datascience/notebook/helper.ts b/src/test/datascience/notebook/helper.ts index 0cfa13f27..fcfbaa48e 100644 --- a/src/test/datascience/notebook/helper.ts +++ b/src/test/datascience/notebook/helper.ts @@ -1421,6 +1421,7 @@ export async function hijackSavePrompt( export class MockQuickPick implements QuickPick { value: string; placeholder: string | undefined; + prompt: string | undefined; get onDidChangeValue(): Event { return this._onDidChangeValueEmitter.event; }