-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Labels
enhancementNew feature or requestNew feature or requestinternalNothing to be added to CHANGELOG, only internal storyNothing to be added to CHANGELOG, only internal story
Description
Task summary
See (resolved) review discussion in PR #1657
local osType
case "$OSTYPE" in
msys*|cygwin*|win32*)
osType="windows-x64"
This is actually wrong. I tested this on Windows@ARM64 and it gives me windows-x64.
However, the architecture does not seem to matter in any of our integration tests.
IMHO this is somehow coming from the replaced MATRIX_OS.
I would suggest that we simply remove the architecture since the method names are only about the operating system: doGetOsType, doIsWindows, doIsMacOs.
If we later need a separation by architecture, we can add another function for that.
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestinternalNothing to be added to CHANGELOG, only internal storyNothing to be added to CHANGELOG, only internal story
Type
Projects
Status
🆕 New