forked from akveo/ng2-smart-table
-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
breaking-changeResolving this issue will introduce a breaking change.Resolving this issue will introduce a breaking change.enhancementNew feature or requestNew feature or request
Description
In this example:
settings: Settings = {
columns: {
id: {
title: 'ID'
},
name: {
title: 'Full Name'
},
username: {
title: 'User Name'
},
email: {
title: 'Email'
}
}
};
The type of the settings property is called Settings, and with today's IDEs (like WebStorm), automatic import is a very handy feature.
So when a class has a common name, like Config or Settings instead of something more specific like Angular2SmartConfig or Angular2SmartSettings, it' becomes a hassle to import bacuse the IDE may import the wrong.
So maybe changing it to something more specific to this package may be better in the future
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
breaking-changeResolving this issue will introduce a breaking change.Resolving this issue will introduce a breaking change.enhancementNew feature or requestNew feature or request