Skip to content

[SUGGESTION] Rename Settings class to a less generic name #173

@joaoa-casagrande

Description

@joaoa-casagrande

In this example:

settings: Settings = {
  columns: {
    id: {
      title: 'ID'
    },
    name: {
      title: 'Full Name'
    },
    username: {
      title: 'User Name'
    },
    email: {
      title: 'Email'
    }
  }
};

The type of the settings property is called Settings, and with today's IDEs (like WebStorm), automatic import is a very handy feature.
So when a class has a common name, like Config or Settings instead of something more specific like Angular2SmartConfig or Angular2SmartSettings, it' becomes a hassle to import bacuse the IDE may import the wrong.
So maybe changing it to something more specific to this package may be better in the future

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changeResolving this issue will introduce a breaking change.enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions