New try…catch at login breaks login on Safari

[ittipatken]

If user enables pop-up blocker, the error modal will show up and prevent login. Previously the pop-up does not show up as well but the login is still working.

[keenthekeen]

My guess is that a blanket try...catch for all exceptions might be the cause.

I've already rolled back the previous build, but the latest version has now been deployed. Please verify whether the issue still occurs.

[ittipatken]

It seems like the issue still persists. Would it be better to remove signInWithPopup and only use signInWithRedirect?

[keenthekeen]

• signInWithRedirect is noticeably slower than signInWithPopup, due to delay in the stage of getRedirectResult.
• We've already implemented signInWithRedirect as a fallback when signInWithPopup fails, so switching entirely to redirect-based login probably won't solve the issue.
• Supporting login on localhost for development purpose is also important.
• I suspect the login issues may be from (1) popup blockers or (2) users accessing via in-app browsers. I will add a notice to the "Signing in" spinner modal advising users to allow popups.
• That said, I still can't reproduce the login problem myself—so I'm troubleshooting this somewhat blindly.

[ittipatken]

The problem occurs due to popup blocker in the Safari on iOS/iPadOS. I would advise against disabling the popup blocker, as it is enabled by default and affects all iOS/iPadOS users.