From 0ead8730dcdc89696ada1fd4223b07646739116e Mon Sep 17 00:00:00 2001 From: ittipat <39715559+ittipatken@users.noreply.github.com> Date: Sun, 12 Oct 2025 09:03:17 +0700 Subject: [PATCH 1/2] perf: replace deprecated module --- src/app/home/course/course.page.spec.ts | 7 +++---- src/app/home/home.page.spec.ts | 6 +++--- src/app/home/list/list.page.spec.ts | 6 +++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/app/home/course/course.page.spec.ts b/src/app/home/course/course.page.spec.ts index ea627cd..c294121 100644 --- a/src/app/home/course/course.page.spec.ts +++ b/src/app/home/course/course.page.spec.ts @@ -3,10 +3,9 @@ import { CoursePage } from './course.page'; import { AngularFireAuth } from '@angular/fire/compat/auth'; import { ActivatedRouteStub, FireAnalyticsStub, FireAuthStub } from '../../stubs'; import { ManService, ManServiceStub } from '../../man.service'; -import { RouterTestingModule } from '@angular/router/testing'; import { AngularFireAnalytics } from '@angular/fire/compat/analytics'; -import { ActivatedRoute } from '@angular/router'; -import { IonicModule } from '@ionic/angular/ionic-module'; +import { ActivatedRoute, provideRouter } from '@angular/router'; +import { IonicModule } from '@ionic/angular'; describe('CoursePage', () => { let component: CoursePage; @@ -14,7 +13,7 @@ describe('CoursePage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), RouterTestingModule, CoursePage], + imports: [IonicModule.forRoot(), provideRouter, CoursePage], providers: [ { provide: ActivatedRoute, useValue: ActivatedRouteStub }, { provide: AngularFireAnalytics, useValue: FireAnalyticsStub }, diff --git a/src/app/home/home.page.spec.ts b/src/app/home/home.page.spec.ts index 0f1898a..ddd5973 100644 --- a/src/app/home/home.page.spec.ts +++ b/src/app/home/home.page.spec.ts @@ -3,8 +3,8 @@ import { HomePage } from './home.page'; import { AngularFireAuth } from '@angular/fire/compat/auth'; import { FireAuthStub } from '../stubs'; import { ManService, ManServiceStub } from '../man.service'; -import { RouterTestingModule } from '@angular/router/testing'; -import { IonicModule } from '@ionic/angular/ionic-module'; +import { IonicModule } from '@ionic/angular'; +import { provideRouter } from '@angular/router'; describe('HomePage', () => { let component: HomePage; @@ -12,7 +12,7 @@ describe('HomePage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), RouterTestingModule, HomePage], + imports: [IonicModule.forRoot(), provideRouter, HomePage], providers: [ { provide: AngularFireAuth, useValue: FireAuthStub }, { provide: ManService, useValue: ManServiceStub } diff --git a/src/app/home/list/list.page.spec.ts b/src/app/home/list/list.page.spec.ts index 741cb6d..9318e30 100644 --- a/src/app/home/list/list.page.spec.ts +++ b/src/app/home/list/list.page.spec.ts @@ -1,9 +1,9 @@ import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'; import { ListPage } from './list.page'; -import { RouterTestingModule } from '@angular/router/testing'; -import { ActivatedRoute } from '@angular/router'; +import { ActivatedRoute, provideRouter } from '@angular/router'; import { ActivatedRouteStub } from '../../stubs'; import { ManService, ManServiceStub } from '../../man.service'; +import { IonicModule } from '@ionic/angular'; describe('ListPage', () => { let component: ListPage; @@ -11,7 +11,7 @@ describe('ListPage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), RouterTestingModule, ListPage], + imports: [IonicModule.forRoot(), provideRouter, ListPage], providers: [ { provide: ActivatedRoute, useValue: ActivatedRouteStub }, { provide: ManService, useValue: ManServiceStub } From dc3ea603190ce1e06e70c8c18f7ff32e782b43f2 Mon Sep 17 00:00:00 2001 From: ittipat <39715559+ittipatken@users.noreply.github.com> Date: Sun, 12 Oct 2025 09:32:32 +0700 Subject: [PATCH 2/2] refactor: remove provideRouter --- src/app/home/course/course.page.spec.ts | 4 ++-- src/app/home/home.page.spec.ts | 3 +-- src/app/home/list/list.page.spec.ts | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/app/home/course/course.page.spec.ts b/src/app/home/course/course.page.spec.ts index c294121..0f8b2c2 100644 --- a/src/app/home/course/course.page.spec.ts +++ b/src/app/home/course/course.page.spec.ts @@ -4,7 +4,7 @@ import { AngularFireAuth } from '@angular/fire/compat/auth'; import { ActivatedRouteStub, FireAnalyticsStub, FireAuthStub } from '../../stubs'; import { ManService, ManServiceStub } from '../../man.service'; import { AngularFireAnalytics } from '@angular/fire/compat/analytics'; -import { ActivatedRoute, provideRouter } from '@angular/router'; +import { ActivatedRoute } from '@angular/router'; import { IonicModule } from '@ionic/angular'; describe('CoursePage', () => { @@ -13,7 +13,7 @@ describe('CoursePage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), provideRouter, CoursePage], + imports: [IonicModule.forRoot(), CoursePage], providers: [ { provide: ActivatedRoute, useValue: ActivatedRouteStub }, { provide: AngularFireAnalytics, useValue: FireAnalyticsStub }, diff --git a/src/app/home/home.page.spec.ts b/src/app/home/home.page.spec.ts index ddd5973..53172cd 100644 --- a/src/app/home/home.page.spec.ts +++ b/src/app/home/home.page.spec.ts @@ -4,7 +4,6 @@ import { AngularFireAuth } from '@angular/fire/compat/auth'; import { FireAuthStub } from '../stubs'; import { ManService, ManServiceStub } from '../man.service'; import { IonicModule } from '@ionic/angular'; -import { provideRouter } from '@angular/router'; describe('HomePage', () => { let component: HomePage; @@ -12,7 +11,7 @@ describe('HomePage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), provideRouter, HomePage], + imports: [IonicModule.forRoot(), HomePage], providers: [ { provide: AngularFireAuth, useValue: FireAuthStub }, { provide: ManService, useValue: ManServiceStub } diff --git a/src/app/home/list/list.page.spec.ts b/src/app/home/list/list.page.spec.ts index 9318e30..5e40312 100644 --- a/src/app/home/list/list.page.spec.ts +++ b/src/app/home/list/list.page.spec.ts @@ -1,6 +1,6 @@ import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'; import { ListPage } from './list.page'; -import { ActivatedRoute, provideRouter } from '@angular/router'; +import { ActivatedRoute } from '@angular/router'; import { ActivatedRouteStub } from '../../stubs'; import { ManService, ManServiceStub } from '../../man.service'; import { IonicModule } from '@ionic/angular'; @@ -11,7 +11,7 @@ describe('ListPage', () => { beforeEach(waitForAsync(() => { TestBed.configureTestingModule({ - imports: [IonicModule.forRoot(), provideRouter, ListPage], + imports: [IonicModule.forRoot(), ListPage], providers: [ { provide: ActivatedRoute, useValue: ActivatedRouteStub }, { provide: ManService, useValue: ManServiceStub }