Global search does not always show all matches

[jeremypw]

What Happened?

Performed a global search (case insensitive, partial words) for a common word - on first attempt only some of the expected files in the sidebar showed badges. Repeating the same search showed successively more badges.

Steps to Reproduce

1. Perform a global search for a term appearing multiple times in a lot of files
2. Notice that on first attempt not all the expected files are badged.

Expected Behavior

All expected matches should appear as badges on the first attempt at a global search.

OS Version

8.x (Circe)

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

Hardware Info

No response

[jeremypw]

This appears to be a consequence of #1522, which also affects expanding the folderitems on startup. expand_to_path () no longer works correctly when the children are loaded asynchronously.