No default_encoding in async request method

[olivierouellet]

I’m trying to modify Home Assistant code to add a default_encoding configuration variable to the REST sensor platform. Since the change from chardet to UTF-8, some websites aren’t decoded properly (those without explicit character encoding declaration).

When using an async request, I get this error :

Unexpected error fetching rest data data: AsyncClient.request() got an unexpected keyword argument 'default_encoding'

Here’s the part of the code in the REST component (data.py) that causes the problem :

        try:
            response = await self._async_client.request(
                self._method,
                self._resource,
                headers=rendered_headers,
                params=rendered_params,
                auth=self._auth,
                content=self._request_data,
                timeout=self._timeout,
                follow_redirects=True,
                default_encoding=self._default_encoding, # This line gives the error 
            )
            self.data = response.text
            self.headers = response.headers

And this is the request method in httpx _client.py

    async def request(
        self,
        method: str,
        url: URLTypes,
        *,
        content: typing.Optional[RequestContent] = None,
        data: typing.Optional[RequestData] = None,
        files: typing.Optional[RequestFiles] = None,
        json: typing.Optional[typing.Any] = None,
        params: typing.Optional[QueryParamTypes] = None,
        headers: typing.Optional[HeaderTypes] = None,
        cookies: typing.Optional[CookieTypes] = None,
        auth: typing.Union[AuthTypes, UseClientDefault, None] = USE_CLIENT_DEFAULT,
        follow_redirects: typing.Union[bool, UseClientDefault] = USE_CLIENT_DEFAULT,
        timeout: typing.Union[TimeoutTypes, UseClientDefault] = USE_CLIENT_DEFAULT,
        extensions: typing.Optional[RequestExtensions] = None,
    ) -> Response:
        """
        Build and send a request.

        Equivalent to:

        ```python
        request = client.build_request(...)
        response = await client.send(request, ...)
        ```

        See `AsyncClient.build_request()`, `AsyncClient.send()`
        and [Merging of configuration][0] for how the various parameters
        are merged with client-level configuration.

        [0]: /advanced/#merging-of-configuration
        """
        request = self.build_request(
            method=method,
            url=url,
            content=content,
            data=data,
            files=files,
            json=json,
            params=params,
            headers=headers,
            cookies=cookies,
            timeout=timeout,
            extensions=extensions,
        )
        return await self.send(request, auth=auth, follow_redirects=follow_redirects)

Would adding the keyword argument for default_encoding to the request method solve the problem? Thanks for your opinion on this.

Maybe I’m not using the library right though. My coding skills are really basic.

[olivierouellet]

Ok, so if I add self._async_client._default_encoding = self._default_encoding before the try , everything seems to work ok. I removed the line of code that was giving me the error.

        self._async_client._default_encoding = self._default_encoding  # Added this line

        try:
            response = await self._async_client.request(
        ...

Beginner's question. Learning every day. If I'm still not doing it right, please let me know.