Skip to content

Error in importable equation eq_Nu_forced_all #105

@schymans

Description

@schymans

In https://github.com/environmentalscience/essm/blob/master/essm/equations/physics/thermodynamics.py, the definition for eq_Nu_forced_all should be:

class eq_Nu_forced_all(Equation):
    """Nu as function of Re and Re_c under forced conditions.

    (Eqs. B13--B15 in :cite:`schymanski_leaf-scale_2017`)
    """

    expr = Eq(
        Nu, S(1) / S(1000) * Pr ** (S(1) / S(3)) * 
        (S(37) * Re ** (S(4) / S(5)) - 
        (S(37) * ((Re + Re_c - abs(Re_c - Re)) / S(2)) ** (S(4) / S(5)) -
        S(664) * ((Re + Re_c - abs(Re_c - Re)) / S(2)) ** (S(1) / S(2))
        )))

The current code states:

class eq_Nu_forced_all(Equation):
    """Nu as function of Re and Re_c under forced conditions.

    (Eqs. B13--B15 in :cite:`schymanski_leaf-scale_2017`)
    """

    expr = Eq(
        Nu, -1 / 1000 * Pr ** (1 / 3) * (
            37 * (Re + Re_c - 1 / 2 * abs(Re - Re_c)) ** (4 / 5) - 37 * Re **
            (4 / 5) - 664 * sqrt(Re + Re_c - 1 / 2 * abs(Re - Re_c))
        )
    )

Note that not only abs(Re-Re_c) has to be divided by 2, but also Re and Re_c just in front of it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions