SimpleInventoryUI Node only displays items when stack count is greater than 1

[Jalkhov]

Well, that, when add items to Inventory, just show icon and stack when its >= x2

Godot_v4.4.1-stable_win64_btGOVpuWDz.mp4

[scriptsengineer]

@Jalkhov Use the "contents_changed" inventory signals to update your UI, it seems to me that your UI may be updating before things happen in the inventory.

[Jalkhov]

First, I want to remind you how I am managing my inventory:

global.gd

var db_res = preload("res://inventory/database.tres")
var Inventario: Inventory = Inventory.new()

func _ready() -> void:
	Inventario.database = db_res

hud script:

@onready var inventoryc: MarginContainer = %InventoryContainer

func _ready():
	$InventoryContainer/SimpleInventoryUI.inventory = Global.Inventario

HUD Node

So, to connect the Inventory Node (Dynamically Generated) to the contents_changed signal would it be like this?:

# It doesn't work.
$InventoryContainer/SimpleInventoryUI.inventory.contents_changed.connect(_on_item_put)

Or should I do it from global.gd?

[scriptsengineer]

If you are using the SimpleInventoryUI demo code, just configuring your inventory should work properly. Have you checked the "simple transfer" code?

[Jalkhov]

I have tested tutorial_02_simple_ui and works fine, shows item when its x1,

So, in my HUD scene, i have placed Inventory Node directly to the the and works fine

Here's the codes

Before

class_name HUD
extends CanvasLayer

# Nodos
@onready var health_bar: ProgressBar = %Health

@onready var money_label: Label = %MoneyCounter
@onready var avatar: TextureRect = %Avatar
@onready var inventoryc: MarginContainer = %InventoryContainer
@onready var sfx_gain_money: AudioStreamPlayer2D = %gain_money
@export var item_id : String

@export var max_health: int = 100
	
func _ready():
	$InventoryContainer/SimpleInventoryUI.inventory = Global.Inventario
	# Conectar las funciones de actualización a las señales del singleton
	Global.health_updated.connect(update_health)
	Global.money_updated.connect(update_money)
	
	inventoryc.focus_mode = Control.FOCUS_ALL
	
	update_health(Global.player_health)
	update_money(Global.player_money)
	
func update_health(current_health: int):
	health_bar.value = current_health
	# Cambio de color según salud
	if current_health < max_health * 0.3:
		health_bar.add_theme_color_override("font_color", Color.RED)
	else:
		health_bar.add_theme_color_override("font_color", Color.WHITE)

func update_money(amount: int):
	money_label.text = "%d Bs" % amount
	#TODO: Diferentes sonidos para ganar y perder dinero
	# sfx_gain_money.play()
	
func _input(event: InputEvent) -> void:
	if event.is_action_pressed("toggle_inventory"):
		inventoryc.visible = !inventoryc.visible
		if inventoryc.visible:
			inventoryc.grab_focus()  # Solo intenta agarrar foco si es visible
		else:
			get_viewport().gui_release_focus()  # Libera el foco

	# Solo procesar acciones del inventario si está visible
	if inventoryc.visible:
		if Input.is_action_just_pressed("interact"):
			print_inventory()
		if Input.is_action_just_pressed("add_item_a"):
			Global.Inventario.add(item_id, 1)
			print_inventory()
		if Input.is_action_just_pressed("remove_item_a"):
			Global.Inventario.remove(item_id, 1)
			print_inventory()

func print_inventory():
	print("Inventory Items:")
	for item in Global.Inventario.stacks:
		if item.item_id != "":
			print(item.item_id," x ", item.amount)
		else:
			print("Empty")

After

class_name HUD
extends CanvasLayer

# Nodos
@onready var health_bar: ProgressBar = %Health

@onready var money_label: Label = %MoneyCounter
@onready var avatar: TextureRect = %Avatar
@onready var inventoryc: MarginContainer = %InventoryContainer
@onready var inventario: Inventory = %Inventario
@onready var sfx_gain_money: AudioStreamPlayer2D = %gain_money
@export var item_id : String

@export var max_health: int = 100
	
func _ready():
	Global.health_updated.connect(update_health)
	Global.money_updated.connect(update_money)
	
	inventoryc.focus_mode = Control.FOCUS_ALL
	
	update_health(Global.player_health)
	update_money(Global.player_money)
	
func _on_item_put(_algo):
	print("Ok")
	
func update_health(current_health: int):
	health_bar.value = current_health
	# Cambio de color según salud
	if current_health < max_health * 0.3:
		health_bar.add_theme_color_override("font_color", Color.RED)
	else:
		health_bar.add_theme_color_override("font_color", Color.WHITE)

func update_money(amount: int):
	money_label.text = "%d Bs" % amount
	#TODO: Diferentes sonidos para ganar y perder dinero
	# sfx_gain_money.play()
	
func _input(_event: InputEvent) -> void:
	if Input.is_action_pressed("toggle_inventory"):
		inventoryc.visible = !inventoryc.visible
		if inventoryc.visible:
			inventoryc.grab_focus()  # Solo intenta agarrar foco si es visible
		else:
			get_viewport().gui_release_focus()  # Libera el foco

	# Solo procesar acciones del inventario si está visible
	if inventoryc.visible:
		if Input.is_action_just_pressed("interact"):
			print_inventory()
		if Input.is_action_just_pressed("add_item_a"):
			inventario.add(item_id, 1)
			print_inventory()
		if Input.is_action_just_pressed("remove_item_a"):
			inventario.remove(item_id, 1)
			print_inventory()

func print_inventory():
	print("Inventory Items:")
	for item in inventario.stacks:
		if item.item_id != "":
			print(item.item_id," x ", item.amount)
		else:
			print("Empty")
	


func _on_inventario_contents_changed() -> void:
	print("Fuck me")

[Jalkhov]

Testing i have maded this:

if inventoryc.visible:
	if Input.is_action_just_pressed("interact"):
		print_inventory()
	if Input.is_action_just_pressed("add_item_a"):
		Global.Inventario.add(item_id, 1)
		Global.Inventario.update_stack(0) # Added this
		print_inventory()
	if Input.is_action_just_pressed("remove_item_a"):
		Global.Inventario.remove(item_id, 1)
		Global.Inventario.update_stack(0)
		print_inventory()

And works, but, its the correct way? I feel that parameter its too static

[scriptsengineer]

But without this update_stack it doesn't work?

[Jalkhov]

No. Perhaps the problem is in how the inventory is declared in the singleton and then assigned to SimpleInventarioUI? I must admit that my knowledge of GDScript is not too deep, all I have said is from reading the Godot documentation and the Plugin-

[Jalkhov]

If you want i can make a minimal version of my project, just with things that doesn't works, soy you can run and test by yourself

[scriptsengineer]

inventory-system/addons/inventory-system-demos/simple-transfer/simple_inventory_ui.gd

Lines 38 to 45 in 0fcb5e3

	func _connect_inventory_signals() -> void:
	if !is_instance_valid(inventory):
	return
	if !inventory.contents_changed.is_connected(_queue_refresh):
	inventory.contents_changed.connect(_queue_refresh)
	if !inventory.updated_stack.is_connected(_on_stack_updated):
	inventory.updated_stack.connect(_on_stack_updated)

If it is the simple inventory ui, it already updates when the inventory has any changes, in the simple transfer ui it works normally.

[Jalkhov]

Which script are you using for ui?

The script you can see ahead, global and hud.

Here is the minimal project, give a chance: https://uploadnow.io/f/R3K31pv

Kp 1 Adds an Orange
Kp 2 Adds an Apple

[scriptsengineer]

Sorry for the delay, there really is a bug in this SimpleInventoryUI script, thanks for insisting on looking into it, haha.

I needed to subscribe to the stack added and stack removed signals.

Here is the fixed version https://github.com/expressobits/inventory-system/blob/addon/addons/inventory-system-demos/simple-transfer/simple_inventory_ui.gd

[Jalkhov]

Mmm i dont understand

This script

https://github.com/expressobits/inventory-system/blob/addon/addons/inventory-system-demos/simple-transfer/simple_inventory_ui.gd

Is it different from the script used by InventoryUI?

Because the Godot editor points to the same one

[scriptsengineer]

I updated it and fixed the problem with signals.