Project1Sam-Ruth - code review

[EmilyDewdrop]

README

• reads more diary-like instead of Why? What How? questions
• Ruth's note features some of the elements of why and how so could be reworked into a final version
• use markdown to add variation in size, headings

User stories

####Meets requirements

• you can see info about each team member
• can click to navigate between sections

####Improvements

• some responsiveness but overflows on smaller devices
• hamburger menu not visible on smaller devices (menu bar not shrinking)

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]

UI bugs

• the jumping form inputs (that go up to the top when you click them) are a bit of a confusing user experience we found, and once you submit half of the words get deleted (so, for example, it says 'r Name')
• on submission an alert appears but would be a better user experience to have a customised page displayed

Instructions

[Does everything work as expected or were there missing instructions?]

File structure

[When you open the project in your editor, does the file structure make sense?]

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

[Do variables and functions have clear and descriptive names?]

Readability

• commented out titles allow reader to easily understand which part of the code does what