Skip to content

Charles-Fearghal-Agency - code review #3

@fintonius

Description

@fintonius

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]

  • The README file is missing the info above

User stories

  • They have met the user stories for the project

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]

  • Most are met apart from form validation

UI bugs

[Can you see any obvious bugs or areas to improve?]

  • Form submits not matter what is inputted.

Instructions

N/A

File structure

  • Looks neat

Flow of control

[ Can you you follow the different paths the code might take?]

  • Yes - it's a simple site

Naming

  • Clear CSS naming structure
  • Semantic HTML used

Readability

  • Only HTML / CSS in main but code is easily readable and clear

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions