Skip to content

[project name] - code review #7

@samscupoftea

Description

@samscupoftea

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]
Their README fulfils all of the requirements as far as we can tell. It is to the point and clear. It include information about each main element and the accessibility features.

User stories

[Does the project meet the user stories for that week?]
There are issues created for different features. The issues appeared to be solved and up to date.

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]
Yes, it appears so.

UI bugs

[Can you see any obvious bugs or areas to improve?]
None.

Instructions

[Does everything work as expected or were there missing instructions?]
The social icons in the footer don't work at the moment.

File structure

[When you open the project in your editor, does the file structure make sense?]
Perhaps put each of the page types i.e HTML, CSS file into separate folders.

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

Some of the code like the JS and CSS could do with some more descriptions or comments to tell which code section is for each.
[Do variables and functions have clear and descriptive names?]

Readability

[Do you understand the code?]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions