docs: fix auth guide examples and k8s troubleshooting values#397
docs: fix auth guide examples and k8s troubleshooting values#397markphelps merged 2 commits intomainfrom
Conversation
PR ReviewThis is a solid accuracy-focused cleanup. The core fixes are correct and important. A few items worth addressing before merging: Bugs / Accuracy Issues1. Stale frontmatter description in connecting-applications.mdx The Since Kubernetes service account auth is now a first-class Method 3, the description should be updated, e.g.: 2. Missing Content-Type header in the Kubernetes token exchange curl example The curl example at the Kubernetes auth step omits a Minor Inconsistencies3. Curl style is inconsistent across examples The static-token and JWT examples use 4. EKS Fargate mentioned twice in kubernetes-troubleshooting.mdx The new What Looks Good
|
Follow-up: Correcting Previous ReviewI need to correct my earlier review — I misread the diff on several points. Point 1 (stale frontmatter description) — incorrect. The description was updated in this PR to include "Kubernetes service account tokens". No issue here. Point 2 (missing Content-Type header in K8s curl example) — incorrect. The Kubernetes token exchange example does include Point 3 (curl style inconsistency) — incorrect. All three curl examples consistently use long-form flags ( Point 4 (EKS Fargate mentioned twice) — still a minor observation, but the PR handles it well: the Corrected AssessmentThis PR is clean and the fixes are accurate:
No blocking issues. The PR is ready to merge. |
Summary
Verification