code urlparse.urlparse(self.uri) has problem in twisted-13.10(windows x64)

[howie1013]

When I set the proxy with server.py and browse https://www.google.com, it outputs the 501 error.
I find the problem is causing by the below

    # when self.uri = www.google.com:443, 
    # parsed is ParseResult(scheme='www.google.com', netloc='', path='443', params='', query='', fragment='')
    parsed = urlparse.urlparse(self.uri) 

And I change the code to below, it runs without any problem.

    uri = self.uri if self.uri.startswith('https://') else 'https://' + self.uri
    parsed = urlparse.urlparse(uri)

[fmoo]

What browser are you using and how have you configured the proxy? I'd like to try to repro and see why the port is getting parsed into the path.

[fmoo]

Also, can you include the value of self.uri before your change? Is it just "www.google.com:443"?

[fmoo]

Or do you have twisted set up in some way to forward the outbound requests through another proxy?

[howie1013]

I use chrome. I debug it and the value of self.uri is just "www.google.com:443"..

[fmoo]

What version of python are you running? I can't repro ParseResult(scheme='www.google.com', netloc='', path='443', params='', query='', fragment='') with 2.7.3

[fmoo]

I can repro this ParseResult(...) if I add a trailing ?, #, or whitespace after the domain in the CONNECT request. I suspect a \r is leaking through. Possibly a windows-specific thing.

When you debug, can you debug repr(self.uri) instead of self.uri? That will explicitly emit any unprintable characters.

[howie1013]

What version of python are you running? I can't repro ParseResult(scheme='
www.google.com', netloc='', path='443', params='', query='', fragment='')with 2.7.3

2.7.5

[howie1013]

When you debug, can you debug repr(self.uri) instead of self.uri? That
will explicitly emit any unprintable characters.

OK.Later I will give you the result.

[fmoo]

Ping. Any updates?

[howie1013]

the repr(self.uri) is ('uri', "'clients4.google.com:443'")

[fmoo]

How is self.uri a tuple? Are you sure you did a log.msg(repr(self.uri)) in server.py in processConnectRequest()?

Passing a tuple to urlparse() throws AttributeError: 'tuple' object has no attribute 'find'

[howie1013]

I use print('uri', repr(self.uri))
2013-11-11 PM2:36ÓÚ "Peter Ruibal" notifications@github.comдµÀ£º

How is self.uri a tuple? Are you sure you did a log.msg(repr(self.uri)) in
server.py in processConnectRequest()?

Passing a tuple to urlparse() throws AttributeError: 'tuple' object has
no attribute 'find'

¡ª
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-28177458
.