From c91fd3de5ff8d257061a51c9c71c724d0a0e9809 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vo=C5=99=C3=AD=C5=A1ek?= Date: Fri, 19 Jan 2024 21:59:14 +0100 Subject: [PATCH 1/2] Do not flash loading class in modal refresh --- src/definitions/modules/modal.js | 3 --- src/definitions/modules/modal.less | 6 ------ src/themes/default/modules/modal.variables | 6 ------ 3 files changed, 15 deletions(-) diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js index 0910750765..26b2f78e77 100755 --- a/src/definitions/modules/modal.js +++ b/src/definitions/modules/modal.js @@ -851,7 +851,6 @@ }, cacheSizes: function () { - $module.addClass(className.loading); var scrollHeight = $module.prop('scrollHeight'); var modalWidth = $module.outerWidth(); var modalHeight = $module.outerHeight(); @@ -867,7 +866,6 @@ }); module.cache.topOffset = -(module.cache.height / 2); } - $module.removeClass(className.loading); module.debug('Caching modal and container sizes', module.cache); }, helpers: { @@ -1394,7 +1392,6 @@ blurring: 'blurring', inverted: 'inverted', legacy: 'legacy', - loading: 'loading', scrolling: 'scrolling', undetached: 'undetached', front: 'front', diff --git a/src/definitions/modules/modal.less b/src/definitions/modules/modal.less index 72fbff620d..85578f3e81 100755 --- a/src/definitions/modules/modal.less +++ b/src/definitions/modules/modal.less @@ -413,12 +413,6 @@ States *******************************/ -.ui.loading.modal { - display: block; - visibility: hidden; - z-index: @loadingZIndex; -} - .ui.active.modal { display: block; } diff --git a/src/themes/default/modules/modal.variables b/src/themes/default/modules/modal.variables index fefb01f2f7..4a20edfc36 100755 --- a/src/themes/default/modules/modal.variables +++ b/src/themes/default/modules/modal.variables @@ -104,12 +104,6 @@ /* Coupling */ @invertedBoxShadow: 1px 3px 10px 2px rgba(0, 0, 0, 0.2); -/* ------------------- - States --------------------- */ - -@loadingZIndex: -1; - /* ------------------- Types -------------------- */ From 57e6d87704e654284a64afaba0acf8ba8f2a5b93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vo=C5=99=C3=AD=C5=A1ek?= Date: Sun, 16 Mar 2025 01:25:02 +0100 Subject: [PATCH 2/2] address feedback --- src/definitions/modules/modal.less | 6 ++++++ src/themes/default/modules/modal.variables | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/src/definitions/modules/modal.less b/src/definitions/modules/modal.less index 85578f3e81..72fbff620d 100755 --- a/src/definitions/modules/modal.less +++ b/src/definitions/modules/modal.less @@ -413,6 +413,12 @@ States *******************************/ +.ui.loading.modal { + display: block; + visibility: hidden; + z-index: @loadingZIndex; +} + .ui.active.modal { display: block; } diff --git a/src/themes/default/modules/modal.variables b/src/themes/default/modules/modal.variables index 4a20edfc36..fefb01f2f7 100755 --- a/src/themes/default/modules/modal.variables +++ b/src/themes/default/modules/modal.variables @@ -104,6 +104,12 @@ /* Coupling */ @invertedBoxShadow: 1px 3px 10px 2px rgba(0, 0, 0, 0.2); +/* ------------------- + States +-------------------- */ + +@loadingZIndex: -1; + /* ------------------- Types -------------------- */