Try to create the sort file at startup.

If a bad path for FORMTMPSORT is specified, FORM doesn't notice until
it tries to create a sort file and can't. In principle one can create
a script which takes a long time to reach this point.

Try to create the file immediately at startup, and Terminate if this
fails.

Author: jodavies

check/features.frm

@@ -1089,3 +1089,13 @@ format C;
 assert succeeded?
 assert !(file("out.c") =~ /[_] [+]=  /)
 *--#] Issue392_ContinuationLines_0 :
+*--#[ TempSortDir :
+#: TempSortDir bad/path
+Local test = 1;
+.end
+if mpi?
+  assert runtime_error?("Could not create sort file: bad/path/0formxxx.sor")
+else
+  assert runtime_error?("Could not create sort file: bad/path/xformxxx.sor")
+end
+*--#] TempSortDir :

sources/startup.c

@@ -799,6 +799,17 @@ classic:;
 	while ( *t ) { *s++ = *t++; i++; }
 	s[-2] = 'o'; *s = 0;
 	}
+/*
+	Try to create the sort file already, so we can Terminate earlier if this fails.
+*/
+	if ( ( AM.S0->file.handle = CreateFile((char *)AM.S0->file.name) ) < 0 ) {
+		MesPrint("Could not create sort file: %s", AM.S0->file.name);
+		Terminate(-1);
+	};
+	/* Close and clean up the test file */
+	CloseFile(AM.S0->file.handle);
+	AM.S0->file.handle = -1;
+	remove(AM.S0->file.name);
 /*
 	With the stage4 and scratch file names we have to be a bit more careful.
 	They are to be allocated after the threads are initialized when there