From a8afb38e4e0aa84efcefcea2bb5137874204d6f2 Mon Sep 17 00:00:00 2001 From: Vivian Qi Date: Mon, 17 Nov 2025 20:10:58 -0500 Subject: [PATCH] made drive controller follow standards --- src/main/java/frc/robot/Robot.java | 9 --------- src/main/java/frc/robot/RobotContainer.java | 10 +++++----- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/src/main/java/frc/robot/Robot.java b/src/main/java/frc/robot/Robot.java index 1305e91..2c13bd6 100644 --- a/src/main/java/frc/robot/Robot.java +++ b/src/main/java/frc/robot/Robot.java @@ -75,15 +75,6 @@ public void teleopInit() { } } - /** This function is called periodically during operator control. */ - @Override - public void teleopPeriodic() { - SmartDashboard.putNumber(("joysticklefty"), m_robotContainer.commandxboxcontroller.getLeftY()); - SmartDashboard.putNumber(("joystickleftx"), m_robotContainer.commandxboxcontroller.getLeftX()); - SmartDashboard.putNumber(("joystickrighty"), m_robotContainer.commandxboxcontroller.getRightY()); - SmartDashboard.putNumber(("joystickrightx"), m_robotContainer.commandxboxcontroller.getRightX()); - } - @Override public void testInit() { // Cancels all running commands at the start of test mode. diff --git a/src/main/java/frc/robot/RobotContainer.java b/src/main/java/frc/robot/RobotContainer.java index ed754d9..c627c95 100644 --- a/src/main/java/frc/robot/RobotContainer.java +++ b/src/main/java/frc/robot/RobotContainer.java @@ -22,7 +22,7 @@ public class RobotContainer { // The robot's subsystems and commands are defined here... private final Drivetrain drivetrain = new Drivetrain(); - public final CommandXboxController commandxboxcontroller = new CommandXboxController(0); + private final CommandXboxController drivecontroller = new CommandXboxController(0); private final double MAX_SPEED_METERS_PER_SECOND = 4.0; /*added array bc the code did not repeat the action when it was set to null. @@ -39,8 +39,8 @@ public RobotContainer() { private void setUpDefaultCommands() { drivetrain.setDefaultCommand(Commands.run( () ->{ - drivetrain.setLeftSpeed(MetersPerSecond.of(commandxboxcontroller.getLeftY() * MAX_SPEED_METERS_PER_SECOND)); - drivetrain.setRightSpeed(MetersPerSecond.of(commandxboxcontroller.getRightY() * MAX_SPEED_METERS_PER_SECOND)); + drivetrain.setLeftSpeed(MetersPerSecond.of(drivecontroller.getLeftY() * MAX_SPEED_METERS_PER_SECOND)); + drivetrain.setRightSpeed(MetersPerSecond.of(drivecontroller.getRightY() * MAX_SPEED_METERS_PER_SECOND)); //drivetrain.setLeftSpeed(MetersPerSecond.of(MAX_SPEED_METERS_PER_SECOND)); //drivetrain.setRightSpeed(MetersPerSecond.of(MAX_SPEED_METERS_PER_SECOND)); System.out.println("yay we did it"); @@ -53,8 +53,8 @@ private void setUpDefaultCommands() { } private void setUpDriverButtonBindings() { - commandxboxcontroller.a().whileTrue(Commands.run(() -> System.out.println("yay we did it"))); - commandxboxcontroller.b().whileTrue(Commands.run(() -> System.out.println("yay we did it"))); + drivecontroller.a().whileTrue(Commands.run(() -> System.out.println("yay we did it"))); + drivecontroller.b().whileTrue(Commands.run(() -> System.out.println("yay we did it"))); }