-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
The ApiClient methods for setting timeouts in the OkHttpClient don't do what their respective documentation states.
ApiClient apiClient = new ApiClient();
apiClient.setConnectTimeout(30000);
apiClient.setReadTimeout(30000);
apiClient.setWriteTimeout(30000);
Expected result: Connect, read and write timeout are set to 30 seconds.
Actual result: Connect, read and write timeout still default to 10 seconds.
I looked at your code, and the setter methods just create a new client and then ignore it:
public ApiClient setConnectTimeout(int connectionTimeout) {
httpClient.newBuilder().connectTimeout(connectionTimeout, TimeUnit.MILLISECONDS).build();
return this;
}
I suggest fixing it by actually assigning the client. Example:
public ApiClient setConnectTimeout(int connectionTimeout) {
this.httpClient = this.httpClient.newBuilder()
.connectTimeout(connectionTimeout, TimeUnit.MILLISECONDS)
.build();
return this;
}
Metadata
Metadata
Assignees
Labels
No labels