-
Notifications
You must be signed in to change notification settings - Fork 65
Description
Summary
votify currently crashes on initialization with a requests.exceptions.HTTPError: 404 caused by a hardcoded external URL that no longer exists:
https://raw.githubusercontent.com/Thereallo1026/spotify-secrets/refs/heads/main/secrets/secretDict.json
This stops the TOTP class from initializing and prevents any further operation (rc=1). This looks like a repo/file deletion on GitHub and votify does not gracefully handle that condition.
Reproduction steps
- Install votify (or use existing copy).
- Run any votify command that triggers initialization, e.g.: try to download a track:
- Observe the exception and crash.
Observed behavior
votify exits with traceback similar to:
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://raw.githubusercontent.com/Thereallo1026/spotify-secrets/refs/heads/main/secrets/secretDict.json
...
File ".../votify/totp.py", line XX, in get_latest_secret
response.raise_for_status()
Expected behavior
If an external secret repository is missing or unreachable, votify should:
- Not crash on startup.
- Fall back to a safe behavior (e.g., try to continue without TOTP, skip privileged endpoints, or provide a user-visible error advising about degraded functionality).
- Ideally attempt graceful fallbacks (cookie-based auth, prompt for credentials, or YouTube resolution) instead of failing hard.