Changed nicknames mess up the game

[Snuupy]

[13:29:14] Snuupy, ishanyx, Pichu, Nascar1996: Welcome to Werewolf, the popular detective/social party game (a theme of Mafia).
[13:29:14] --- phpwolf sets modes [##phpwolf +m]
[13:29:14] It is now nighttime. All players check for PMs from me for instructions. If you did not receive one, simply sit back, relax, and wait patiently for morning.
[13:29:20] Night lasted 00:06. It is now daytime. The villagers awake, thankful for surviving the night, and search the village...
[13:29:20] The dead body of ishanyx, a villager, is found. Those remaining mourn his/her death.
[13:29:20] --- phpwolf sets modes [##phpwolf -v ishanyx]
[13:29:20] The villagers must now vote for whom to lynch. Use "!lynch " to cast your vote. 2 votes are required to lynch.
[13:29:26] ish safe
[13:29:27] >: (
[13:29:29] !vote Nascar1996
[13:29:30] lol
[13:29:30] Snuupy votes for Nascar1996.
[13:29:30] --- Nascar1996 is now known as FormulaOne1996
[13:29:39] <seer
[13:29:45] !votes
[13:29:46] FormulaOne1996: Nascar1996: 1 (Snuupy)
[13:29:46] FormulaOne1996: 2 players, 2 votes required to lynch, 2 players available to vote.
[13:29:50] xD
[13:29:51] I'm seer
[13:29:52] lol
[13:29:52] !lynch Nas
[13:29:58] !lynch Nascar1996
[13:30:05] dafaq
[13:30:10] LOLOLOL
[13:30:14] !vote for
[13:30:15] Pichu votes for FormulaOne1996.
[13:30:16] Snuupy: lynch me
[13:30:19] !lynch FormulaOne1996
[13:30:20] FormulaOne1996 votes for FormulaOne1996.
[13:30:20] The mob drags a protesting FormulaOne1996 to the hanging tree. S/He succumbs to the will of the horde, and is hanged. It is discovered (s)he was a villager.
[13:30:20] --- phpwolf sets modes [##phpwolf -v FormulaOne1996]
[13:30:20] Game over! There are the same number of wolves as villagers. The wolves eat everyone and win.
[13:30:20] Game lasted 01:06. 01:00 was day. 00:06 was night.
[13:30:20] The wolf was Nascar1996. The seer was Snuupy.
[13:30:20] --- phpwolf sets modes [##phpwolf -m]

[ceradon]

Fixed this bug.

[gluxon]

We need to discuss a potentially different way to store the nicks.

[gluxon]

Here's the issue as it stands. There are two big ones.

• Data stored as arrays are not all the same type of array. Some are indexed, others are associative. A more complex loop detecting the difference between the two is required for this.
• This is the big one. For the associative arrays, you can't just change their value. Some of the nicks are stored as the array key. This means that their values can't be changed. They have to be deleted and reinserted. The problem with this is that it re-arranges the array. This causes problems, though the only one I can think of at the moment is $wolf_killed.

If there's a way to change the array key without deleted it, our problem would be solved. Without it, there are two solutions

• Reconstruct entire arrays if they are associative to retain their order. This is ugly, and I'd rather not do it.
• In every array, store players as a primary key (id) instead of their actual nick. Then have a database correlating players with their key. This prevents the need to update all arrays, instead, only 1. This is also slightly ugly (but less so). I think pywolf does this, but I'm not certain.

The second solution is probably the one I'm going to go with.

[gluxon]

http://stackoverflow.com/questions/8883974/change-array-key-without-changing-order