Build failing on Cygwin

[badgerwithagun]

Not sure if this is likely to be considered important, but... with:

• JAVA_HOME set to a 1.8 JDK
• Maven for Windows installed and added to PATH.
• Guava dependency updated as per this pull request.

Ran mvn install and got a large number of tests failed. Looks like it's related to path separators.

Tests in error: 
  testOneSubmittedMigration_equivalent(com.google.devtools.moe.client.directives.BookkeepingDirectiveTest): String index out of range: -1
  testHeadsEquivalent(com.google.devtools.moe.client.directives.BookkeepingDirectiveTest): String index out of range: -1
  testOneSubmittedMigration_nonEquivalent(com.google.devtools.moe.client.directives.BookkeepingDirectiveTest): String index out of range: -1
  testLongStderr(com.google.devtools.moe.client.SystemCommandRunnerTest): Running perl with args [-e, print STDERR ("*" x 17000)] returned 255 with stdout  and stderr Number found where operator expected at -e line 1, near "* x 17000"(..)
  testLongStdout(com.google.devtools.moe.client.SystemCommandRunnerTest): Running perl with args [-e, print ("*" x 17000)] returned 255 with stdout  and stderr Number found where operator expected at -e line 1, near "* x 17000"(..)
  testFileToString(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testSetLifetime(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\tmp\moe_persistent_0
  testCleanUpTempDirs(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\tmp\moe_persistent_0
  testWrite(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\src
  testListFiles(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testIsDirectory(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testCopyFile(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testMakeDirs(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\a\b\c\d
  testMakeDirsForFile(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\a\b\c\d
  testFindFiles(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testGetResourceAsFile(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\tmp\moe_resource_extraction__0\test_resource
  testExists(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testIsFile(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): String index out of range: -1
  testGetTemporaryDirectory(com.google.devtools.moe.client.testing.InMemoryFileSystemTest): An absolute path was expected: C:\tmp\moe_pineapple_0

[badgerwithagun]

One or two might be due to me piping stdout, actually...

[cgruber]

Yeah - we have very little facility to consistently test on windows, and deal with some of the variations that the windows filesystem implies. We definitely make unix assumptions. I'm nearly certain we won't prioritize this, but I'd be willing to take a pull request.

…

On Tue, 13 Jun 2017 at 02:58 Graham Crockford ***@***.***> wrote: One or two might be due to me piping stdout, actually... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUN4sbCSU8CPahLJu4YA_dlH_HzfsPFks5sDl07gaJpZM4N4Qih> .