From 39168625f45a7a07e4f5fe10cc786d08feb2257e Mon Sep 17 00:00:00 2001 From: Zheng Huang Date: Tue, 5 Mar 2024 07:10:26 +0000 Subject: [PATCH] Fix building issues --- README.md | 2 +- cmake/BinDiffDeps.cmake | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index bd9ae6b9..a00f805a 100644 --- a/README.md +++ b/README.md @@ -116,7 +116,7 @@ cmake -S . -B build/out -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=build/out \ -DBINDIFF_BINEXPORT_DIR=build/binexport \ - "-DIdaSdk_ROOT_DIR=${PWD}build/idasdk" + "-DIdaSdk_DIR=${PWD}/build/idasdk" ``` Finally, invoke the actual build. Binaries will be placed in diff --git a/cmake/BinDiffDeps.cmake b/cmake/BinDiffDeps.cmake index 057b9783..d55b853a 100644 --- a/cmake/BinDiffDeps.cmake +++ b/cmake/BinDiffDeps.cmake @@ -31,4 +31,4 @@ endif() # Setup IDA SDK. Uses FindIdaSdk.cmake from BinExport find_package(IdaSdk) -find_package(Protobuf 3.14 REQUIRED) # Make protobuf_generate_cpp available +find_package(Protobuf 4.25 REQUIRED) # Make protobuf_generate_cpp available